#909: Update tests to JUnit 5

By: DerFrZocker <derrieple@gmail.com>
This commit is contained in:
Bukkit/Spigot
2023-09-24 06:09:10 +10:00
parent eef02e5dd2
commit 2a6d2d27d7
50 changed files with 837 additions and 863 deletions

View File

@@ -1,9 +1,9 @@
package org.bukkit.metadata;
import static org.junit.Assert.*;
import static org.junit.jupiter.api.Assertions.*;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.TestPlugin;
import org.junit.Test;
import org.junit.jupiter.api.Test;
public class FixedMetadataValueTest {
private Plugin plugin = new TestPlugin("X");
@@ -21,7 +21,7 @@ public class FixedMetadataValueTest {
subject = new FixedMetadataValue(plugin, new Integer(5));
assertEquals(new Integer(5), subject.value());
assertEquals(5, subject.asInt());
assertEquals(true, subject.asBoolean());
assertTrue(subject.asBoolean());
assertEquals(5, subject.asByte());
assertEquals(5.0, subject.asFloat(), 0.1e-8);
assertEquals(5.0D, subject.asDouble(), 0.1e-8D);

View File

@@ -1,9 +1,9 @@
package org.bukkit.metadata;
import static org.junit.Assert.*;
import static org.junit.jupiter.api.Assertions.*;
import java.util.concurrent.Callable;
import org.bukkit.plugin.TestPlugin;
import org.junit.Test;
import org.junit.jupiter.api.Test;
public class LazyMetadataValueTest {
private LazyMetadataValue subject;
@@ -41,7 +41,7 @@ public class LazyMetadataValueTest {
assertEquals(value, subject.value());
}
@Test(expected = MetadataEvaluationException.class)
@Test
public void testEvalException() {
subject = new LazyMetadataValue(plugin, LazyMetadataValue.CacheStrategy.CACHE_AFTER_FIRST_EVAL, new Callable<Object>() {
@Override
@@ -49,7 +49,7 @@ public class LazyMetadataValueTest {
throw new RuntimeException("Gotcha!");
}
});
subject.value();
assertThrows(MetadataEvaluationException.class, () -> subject.value());
}
@Test

View File

@@ -15,10 +15,10 @@
package org.bukkit.metadata;
import static org.junit.Assert.*;
import static org.junit.jupiter.api.Assertions.*;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.TestPlugin;
import org.junit.Test;
import org.junit.jupiter.api.Test;
/**
*/
@@ -40,7 +40,7 @@ public class MetadataConversionTest {
assertEquals(10, subject.asLong());
assertEquals(10, subject.asShort());
assertEquals(10, subject.asByte());
assertEquals(true, subject.asBoolean());
assertTrue(subject.asBoolean());
assertEquals("10", subject.asString());
}
@@ -54,7 +54,7 @@ public class MetadataConversionTest {
assertEquals(10, subject.asLong());
assertEquals(10, subject.asShort());
assertEquals(10, subject.asByte());
assertEquals(true, subject.asBoolean());
assertTrue(subject.asBoolean());
assertEquals("10.5", subject.asString());
}
@@ -68,7 +68,7 @@ public class MetadataConversionTest {
assertEquals(10, subject.asLong());
assertEquals(10, subject.asShort());
assertEquals(10, subject.asByte());
assertEquals(false, subject.asBoolean());
assertFalse(subject.asBoolean());
assertEquals("10", subject.asString());
}
@@ -82,7 +82,7 @@ public class MetadataConversionTest {
assertEquals(0, subject.asLong());
assertEquals(0, subject.asShort());
assertEquals(0, subject.asByte());
assertEquals(true, subject.asBoolean());
assertTrue(subject.asBoolean());
assertEquals("true", subject.asString());
}
@@ -96,7 +96,7 @@ public class MetadataConversionTest {
assertEquals(0, subject.asLong());
assertEquals(0, subject.asShort());
assertEquals(0, subject.asByte());
assertEquals(false, subject.asBoolean());
assertFalse(subject.asBoolean());
assertEquals("", subject.asString());
}
}

View File

@@ -1,11 +1,11 @@
package org.bukkit.metadata;
import static org.junit.Assert.*;
import static org.junit.jupiter.api.Assertions.*;
import java.util.List;
import java.util.concurrent.Callable;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.TestPlugin;
import org.junit.Test;
import org.junit.jupiter.api.Test;
public class MetadataStoreTest {
private Plugin pluginX = new TestPlugin("x");

View File

@@ -1,9 +1,9 @@
package org.bukkit.metadata;
import static org.junit.Assert.*;
import static org.junit.jupiter.api.Assertions.*;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.TestPlugin;
import org.junit.Test;
import org.junit.jupiter.api.Test;
public class MetadataValueAdapterTest {
private TestPlugin plugin = new TestPlugin("x");
@@ -38,25 +38,25 @@ public class MetadataValueAdapterTest {
@Test
public void testBooleanConversion() {
// null is False.
assertEquals(false, simpleValue(null).asBoolean());
assertFalse(simpleValue(null).asBoolean());
// String to boolean.
assertEquals(true, simpleValue("True").asBoolean());
assertEquals(true, simpleValue("TRUE").asBoolean());
assertEquals(false, simpleValue("false").asBoolean());
assertTrue(simpleValue("True").asBoolean());
assertTrue(simpleValue("TRUE").asBoolean());
assertFalse(simpleValue("false").asBoolean());
// Number to boolean.
assertEquals(true, simpleValue(1).asBoolean());
assertEquals(true, simpleValue(5.0).asBoolean());
assertEquals(false, simpleValue(0).asBoolean());
assertEquals(false, simpleValue(0.1).asBoolean());
assertTrue(simpleValue(1).asBoolean());
assertTrue(simpleValue(5.0).asBoolean());
assertFalse(simpleValue(0).asBoolean());
assertFalse(simpleValue(0.1).asBoolean());
// Boolean as boolean, of course.
assertEquals(true, simpleValue(Boolean.TRUE).asBoolean());
assertEquals(false, simpleValue(Boolean.FALSE).asBoolean());
assertTrue(simpleValue(Boolean.TRUE).asBoolean());
assertFalse(simpleValue(Boolean.FALSE).asBoolean());
// any object that is not null and not a Boolean, String, or Number is true.
assertEquals(true, simpleValue(new Object()).asBoolean());
assertTrue(simpleValue(new Object()).asBoolean());
}
/** Test String conversions return an empty string when given null. */