[BREAKING] Update BlockFace directions. Fixes BUKKIT-1567, BUKKIT-3069

If you use BlockFace in any way, to compensate the directionals being incorrect, you can still have backwards compatibility if you add in the handling in your plugin:
boolean legacyBlockFace = BlockFace.NORTH().getModX() == -1; (and then handle it accordingly)

If you didn't special case your directions to fix what's being fixed here... Hurray! Your plugin should now work.

By: feildmaster <admin@feildmaster.com>

paper-api/src/main/java/org/bukkit/material/Diode.java

@@ -56,19 +56,19 @@ public class Diode extends MaterialData implements Directional {
         byte data;
 
         switch (face) {
-        case SOUTH:
+        case EAST:
             data = 0x1;
             break;
 
-        case WEST:
+        case SOUTH:
             data = 0x2;
             break;
 
-        case NORTH:
+        case WEST:
             data = 0x3;
             break;
 
-        case EAST:
+        case NORTH:
         default:
             data = 0x0;
         }
@@ -83,16 +83,16 @@ public class Diode extends MaterialData implements Directional {
         switch (data) {
         case 0x0:
         default:
-            return BlockFace.EAST;
+            return BlockFace.NORTH;
 
         case 0x1:
-            return BlockFace.SOUTH;
+            return BlockFace.EAST;
 
         case 0x2:
-            return BlockFace.WEST;
+            return BlockFace.SOUTH;
 
         case 0x3:
-            return BlockFace.NORTH;
+            return BlockFace.WEST;
         }
     }