Fix some javadoc warnings

Also remove a couple old/broken deprecated methods

By: md_5 <git@md-5.net>

paper-api/src/main/java/org/bukkit/potion/Potion.java

@@ -26,7 +26,6 @@ public class Potion {
      * water bottle.
      *
      * @param type The potion type
-     * @see #Potion(int)
      */
     public Potion(@NotNull PotionType type) {
         Validate.notNull(type, "Null PotionType");
@@ -77,14 +76,6 @@ public class Potion {
         this.extended = extended;
     }
 
-    /**
-     * @deprecated
-     */
-    @Deprecated
-    public Potion(int name) {
-        this(PotionType.WATER);
-    }
-
     /**
      * Chain this to the constructor to make the potion a splash potion.
      *

paper-api/src/main/java/org/bukkit/potion/PotionBrewer.java

@@ -37,6 +37,8 @@ public interface PotionBrewer {
      * a potion with the given type.
      *
      * @param type The type of the potion
+     * @param upgraded Whether the potion is upgraded
+     * @param extended Whether the potion is extended
      * @return The list of effects
      */
     @NotNull

paper-api/src/main/java/org/bukkit/potion/PotionType.java

@@ -1,6 +1,5 @@
 package org.bukkit.potion;
 
-import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.Nullable;
 
 /**
@@ -71,29 +70,13 @@ public enum PotionType {
         return extendable;
     }
 
-    /**
-     * @deprecated Non-functional
-     */
-    @Deprecated
-    public int getDamageValue() {
-        return this.ordinal();
-    }
-
     public int getMaxLevel() {
         return upgradeable ? 2 : 1;
     }
 
     /**
-     * @deprecated Non-functional
-     */
-    @Deprecated
-    @Nullable
-    @Contract("_ -> null")
-    public static PotionType getByDamageValue(int damage) {
-        return null;
-    }
-
-    /**
+     * @param effectType the effect to get by
+     * @return the matching potion type
      * @deprecated Misleading
      */
     @Deprecated