Removed some old deprecated code and clean up javadocs + warnings

By: Erik Broes <erikbroes@grum.nl>

paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftBlock.java

@@ -25,20 +25,10 @@ public class CraftBlock implements Block {
         this.chunk = chunk;
     }
 
-    /**
-     * Gets the world which contains this Block
-     *
-     * @return World containing this block
-     */
     public World getWorld() {
         return chunk.getWorld();
     }
 
-    /**
-     * Gets the Location of the block
-     *
-     * @return Location of the block
-     */
     public Location getLocation() {
         return new Location(getWorld(), x, y, z);
     }
@@ -47,47 +37,22 @@ public class CraftBlock implements Block {
         return new BlockVector(x, y, z);
     }
 
-    /**
-     * Gets the x-coordinate of this block
-     *
-     * @return x-coordinate
-     */
     public int getX() {
         return x;
     }
 
-    /**
-     * Gets the y-coordinate of this block
-     *
-     * @return y-coordinate
-     */
     public int getY() {
         return y;
     }
 
-    /**
-     * Gets the z-coordinate of this block
-     *
-     * @return z-coordinate
-     */
     public int getZ() {
         return z;
     }
 
-    /**
-     * Gets the chunk which contains this block
-     *
-     * @return Containing Chunk
-     */
     public Chunk getChunk() {
         return chunk;
     }
 
-    /**
-     * Sets the metadata for this block
-     *
-     * @param data New block specific metadata
-     */
     public void setData(final byte data) {
         chunk.getHandle().world.setData(x, y, z, data);
     }
@@ -100,30 +65,14 @@ public class CraftBlock implements Block {
         }
     }
 
-    /**
-     * Gets the metadata for this block
-     *
-     * @return block specific metadata
-     */
     public byte getData() {
         return (byte) chunk.getHandle().getData(this.x & 0xF, this.y & 0x7F, this.z & 0xF);
     }
 
-    /**
-     * Sets the type of this block
-     *
-     * @param type Material to change this block to
-     */
     public void setType(final Material type) {
         setTypeId(type.getId());
     }
 
-    /**
-     * Sets the type-id of this block
-     *
-     * @param type Type-Id to change this block to
-     * @return whether the block was changed
-     */
     public boolean setTypeId(final int type) {
         return chunk.getHandle().world.setTypeId(x, y, z, type);
     }
@@ -148,80 +97,30 @@ public class CraftBlock implements Block {
         }
     }
 
-    /**
-     * Gets the type of this block
-     *
-     * @return block type
-     */
     public Material getType() {
         return Material.getMaterial(getTypeId());
     }
 
-    /**
-     * Gets the type-id of this block
-     *
-     * @return block type-id
-     */
     public int getTypeId() {
         return chunk.getHandle().getTypeId(this.x & 0xF, this.y & 0x7F, this.z & 0xF);
     }
 
-    /**
-     * Gets the light level between 0-15
-     *
-     * @return light level
-     */
     public byte getLightLevel() {
         return (byte) chunk.getHandle().world.getLightLevel(this.x, this.y, this.z);
     }
 
-    /**
-     * Gets the block at the given face
-     *
-     * @param face Face of this block to return
-     * @return Block at the given face
-     */
     public Block getFace(final BlockFace face) {
         return getRelative(face, 1);
     }
 
-    /**
-     * Gets the block at the given distance of the given face<br />
-     * <br />
-     * For example, the following method places water at 100,102,100; two blocks
-     * above 100,100,100.
-     * <pre>
-     * Block block = world.getBlockAt(100,100,100);
-     * Block shower = block.getFace(BlockFace.UP, 2);
-     * shower.setType(Material.WATER);
-     * </pre>
-     *
-     * @param face Face of this block to return
-     * @param distance Distance to get the block at
-     * @return Block at the given face
-     */
     public Block getFace(final BlockFace face, final int distance) {
         return getRelative(face, distance);
     }
 
-    /**
-     * Gets the block at the given offsets
-     *
-     * @param modX X-coordinate offset
-     * @param modY Y-coordinate offset
-     * @param modZ Z-coordinate offset
-     * @return Block at the given offsets
-     */
     public Block getRelative(final int modX, final int modY, final int modZ) {
         return getWorld().getBlockAt(getX() + modX, getY() + modY, getZ() + modZ);
     }
 
-    /**
-     * Gets the block at the given offsets
-     *
-     * @param face face
-     * @return Block at the given offsets
-     */
     public Block getRelative(BlockFace face) {
         return getRelative(face, 1);
     }
@@ -230,22 +129,6 @@ public class CraftBlock implements Block {
         return getRelative(face.getModX() * distance, face.getModY() * distance, face.getModZ() * distance);
     }
 
-    /**
-     * Gets the face relation of this block compared to the given block<br />
-     * <br />
-     * For example:
-     * <pre>
-     * Block current = world.getBlockAt(100, 100, 100);
-     * Block target = world.getBlockAt(100, 101, 100);
-     *
-     * current.getFace(target) == BlockFace.UP;
-     * </pre>
-     * <br />
-     * If the given block is not connected to this block, null may be returned
-     *
-     * @param block Block to compare against this block
-     * @return BlockFace of this block which has the requested block, or null
-     */
     public BlockFace getFace(final Block block) {
         BlockFace[] values = BlockFace.values();
 

paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftBlockState.java

@@ -10,7 +10,6 @@ import org.bukkit.block.BlockState;
 import org.bukkit.craftbukkit.CraftChunk;
 import org.bukkit.craftbukkit.CraftWorld;
 import org.bukkit.material.MaterialData;
-import net.minecraft.server.WorldServer;
 
 public class CraftBlockState implements BlockState {
     private final CraftWorld world;

paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftChest.java

@@ -7,11 +7,6 @@ import org.bukkit.craftbukkit.CraftWorld;
 import org.bukkit.craftbukkit.inventory.CraftInventory;
 import org.bukkit.inventory.Inventory;
 
-/**
- * Represents a chest.
- *
- * @author sk89q
- */
 public class CraftChest extends CraftBlockState implements Chest {
     private final CraftWorld world;
     private final TileEntityChest chest;

paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftDispenser.java

@@ -10,11 +10,6 @@ import org.bukkit.craftbukkit.CraftWorld;
 import org.bukkit.craftbukkit.inventory.CraftInventory;
 import org.bukkit.inventory.Inventory;
 
-/**
- * Represents a dispenser.
- *
- * @author sk89q
- */
 public class CraftDispenser extends CraftBlockState implements Dispenser {
     private final CraftWorld world;
     private final TileEntityDispenser dispenser;

paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java

@@ -7,11 +7,6 @@ import org.bukkit.craftbukkit.CraftWorld;
 import org.bukkit.craftbukkit.inventory.CraftInventory;
 import org.bukkit.inventory.Inventory;
 
-/**
- * Represents a furnace.
- *
- * @author sk89q
- */
 public class CraftFurnace extends CraftBlockState implements Furnace {
     private final CraftWorld world;
     private final TileEntityFurnace furnace;

paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftNoteBlock.java

@@ -9,9 +9,6 @@ import org.bukkit.block.Block;
 import org.bukkit.block.NoteBlock;
 import org.bukkit.craftbukkit.CraftWorld;
 
-/**
- * Represents a note block.
- */
 public class CraftNoteBlock extends CraftBlockState implements NoteBlock {
     private final CraftWorld world;
     private final TileEntityNote note;