Deprecate magic values

By: Wesley Wolfe <weswolf@aol.com>

paper-api/src/main/java/org/bukkit/block/Block.java

@@ -21,7 +21,9 @@ public interface Block extends Metadatable {
      * Gets the metadata for this block
      *
      * @return block specific metadata
+     * @deprecated Magic value
      */
+    @Deprecated
     byte getData();
 
     /**
@@ -74,7 +76,9 @@ public interface Block extends Metadatable {
      * Gets the type-id of this block
      *
      * @return block type-id
+     * @deprecated Magic value
      */
+    @Deprecated
     int getTypeId();
 
     /**
@@ -156,7 +160,9 @@ public interface Block extends Metadatable {
      * Sets the metadata for this block
      *
      * @param data New block specific metadata
+     * @deprecated Magic value
      */
+    @Deprecated
     void setData(byte data);
 
     /**
@@ -164,7 +170,9 @@ public interface Block extends Metadatable {
      *
      * @param data New block specific metadata
      * @param applyPhysics False to cancel physics from the changed block.
+     * @deprecated Magic value
      */
+    @Deprecated
     void setData(byte data, boolean applyPhysics);
 
     /**
@@ -179,7 +187,9 @@ public interface Block extends Metadatable {
      *
      * @param type Type-Id to change this block to
      * @return whether the block was changed
+     * @deprecated Magic value
      */
+    @Deprecated
     boolean setTypeId(int type);
 
     /**
@@ -188,7 +198,9 @@ public interface Block extends Metadatable {
      * @param type Type-Id to change this block to
      * @param applyPhysics False to cancel physics on the changed block.
      * @return whether the block was changed
+     * @deprecated Magic value
      */
+    @Deprecated
     boolean setTypeId(int type, boolean applyPhysics);
 
     /**
@@ -198,7 +210,9 @@ public interface Block extends Metadatable {
      * @param data The data value to change this block to
      * @param applyPhysics False to cancel physics on the changed block
      * @return whether the block was changed
+     * @deprecated Magic value
      */
+    @Deprecated
     boolean setTypeIdAndData(int type, byte data, boolean applyPhysics);
 
     /**

paper-api/src/main/java/org/bukkit/block/BlockState.java

@@ -42,7 +42,9 @@ public interface BlockState extends Metadatable {
      * Gets the type-id of this block
      *
      * @return block type-id
+     * @deprecated Magic value
      */
+    @Deprecated
     int getTypeId();
 
     /**
@@ -121,7 +123,9 @@ public interface BlockState extends Metadatable {
      *
      * @param type Type-Id to change this block to
      * @return Whether it worked?
+     * @deprecated Magic value
      */
+    @Deprecated
     boolean setTypeId(int type);
 
     /**
@@ -172,11 +176,15 @@ public interface BlockState extends Metadatable {
 
     /**
      * @return The data as a raw byte.
+     * @deprecated Magic value
      */
+    @Deprecated
     public byte getRawData();
 
     /**
      * @param data The new data value for the block.
+     * @deprecated Magic value
      */
+    @Deprecated
     public void setRawData(byte data);
 }

paper-api/src/main/java/org/bukkit/block/Chest.java

@@ -6,6 +6,7 @@ import org.bukkit.inventory.Inventory;
  * Represents a chest.
  */
 public interface Chest extends BlockState, ContainerBlock {
+
     /**
      * Returns the chest's inventory. If this is a double chest, it returns just
      * the portion of the inventory linked to this half of the chest.

paper-api/src/main/java/org/bukkit/block/NoteBlock.java

@@ -19,7 +19,9 @@ public interface NoteBlock extends BlockState {
      * Gets the note.
      *
      * @return The note ID.
+     * @deprecated Magic value
      */
+    @Deprecated
     public byte getRawNote();
 
     /**
@@ -33,7 +35,9 @@ public interface NoteBlock extends BlockState {
      * Set the note.
      *
      * @param note The note ID.
+     * @deprecated Magic value
      */
+    @Deprecated
     public void setRawNote(byte note);
 
     /**
@@ -51,7 +55,9 @@ public interface NoteBlock extends BlockState {
      * @param instrument Instrument ID
      * @param note Note ID
      * @return true if successful, otherwise false
+     * @deprecated Magic value
      */
+    @Deprecated
     public boolean play(byte instrument, byte note);
 
     /**

paper-api/src/main/java/org/bukkit/block/PistonMoveReaction.java

@@ -31,7 +31,9 @@ public enum PistonMoveReaction {
 
     /**
      * @return The ID of the move reaction
+     * @deprecated Magic value
      */
+    @Deprecated
     public int getId() {
         return this.id;
     }
@@ -39,7 +41,9 @@ public enum PistonMoveReaction {
     /**
      * @param id An ID
      * @return The move reaction with that ID
+     * @deprecated Magic value
      */
+    @Deprecated
     public static PistonMoveReaction getById(int id) {
         return byId.get(id);
     }