Commit Graph

3762 Commits

Author SHA1 Message Date
CraftBukkit/Spigot 3a23c54a91 Fix server crash with BlockPopulator when entities are at a negative chunk border
By: DerFrZocker <derrieple@gmail.com>
2021-08-16 07:07:13 +02:00
CraftBukkit/Spigot c2e4e91b1b SPIGOT-5880, SPIGOT-5567: New ChunkGenerator API
## **Current API**
The current world generation API is very old and limited when you want to make more complex world generation. Resulting in some hard to fix bugs such as that you cannot modify blocks outside the chunk in the BlockPopulator (which should and was per the docs possible), or strange behavior such as SPIGOT-5880.

## **New API**
With the new API, the generation is more separate in multiple methods and is more in line with Vanilla chunk generation. The new API is designed to as future proof as possible. If for example a new generation step is added it can easily also be added as a step in API by simply creating the method for it. On the other side if a generation step gets removed, the method can easily be called after another, which is the case with surface and bedrock. The new API and changes are also fully backwards compatible with old chunk generators.

### **Changes in the new api**
**Extra generation steps:**
Noise, surface, bedrock and caves are added as steps. With those generation steps three extra methods for Vanilla generation are also added. Those new methods provide the ChunkData instead of returning one. The reason for this is, that the ChunkData is now backed by a ChunkAccess. With this, each step has the information of the step before and the Vanilla information (if chosen by setting a 'should' method to true). The old method is deprecated.

**New class BiomeProvider**
The BiomeProvider acts as Biome source and wrapper for the NMS class WorldChunkManager. With this the underlying Vanilla ChunkGeneration knows which Biome to use for the structure and decoration generation. (Fixes: SPIGOT-5880). Although the List of Biomes which is required in BiomeProvider, is currently not much in use in Vanilla, I decided to add it to future proof the API when it may be required in later versions of Minecraft.
The BiomeProvider is also separated from the ChunkGenerator for plugins which only want to change the biome map, such as single Biome worlds or if some biomes should be more present than others.

**Deprecated isParallelCapable**
Mojang has and is pushing to a more multi threaded chunk generation. This should also be the case for custom chunk generators. This is why the new API only supports multi threaded generation. This does not affect the old API, which is still checking this.

**Base height method added**
This method was added to also bring the Minecraft generator and Bukkit generator more in line. With this it is possible to return the max height of a location (before decorations). This is useful to let most structures know were to place them. This fixes SPIGOT-5567. (This fixes not all structures placement, desert pyramids for example are still way up at y-level 64, This however is more a vanilla bug and should be fixed at Mojangs end).

**WorldInfo Class**
The World object was swapped for a WorldInfo object. This is because many methods of the World object won't work during world generation and would mostly likely result in a deadlock. It contains any information a plugin should need to identify the world.

**BlockPopulator Changes**
Instead of directly manipulating a chunk, changes are now made to a new class LimitedRegion, this class provides methods to populated the chunk and its surrounding area. The wrapping is done so that the population can be moved into the place where Minecraft generates decorations. Where there is no chunk to access yet. By moving it into this place the generation is now async and the surrounding area of the chunk can also be used.

For common methods between the World and LimitedRegion a RegionAccessor was added.

By: DerFrZocker <derrieple@gmail.com>
2021-08-15 08:08:16 +10:00
CraftBukkit/Spigot fdefaeeccd Update ASM and add support for Java 17
By: md_5 <git@md-5.net>
2021-08-13 08:45:32 +10:00
CraftBukkit/Spigot 3483bd08b3 #913: Handle campfire damage with EntityDamageByBlockEvent
By: Doc <nachito94@msn.com>
2021-08-11 19:05:08 +10:00
CraftBukkit/Spigot 6d08059769 Add dimension setting getters to World
By: Doc <nachito94@msn.com>
2021-08-11 18:57:16 +10:00
CraftBukkit/Spigot 72591f6038 SPIGOT-2222, SPIGOT-6687: Pre-set keepLevel and only use it
By: DerFrZocker <derrieple@gmail.com>
2021-08-11 18:49:49 +10:00
CraftBukkit/Spigot 4a49f6bf8b SPIGOT-6692: Add sendSignChange overload with a hasGlowingText parameter
By: Brokkonaut <hannos17@gmx.de>
2021-08-05 08:43:03 +10:00
CraftBukkit/Spigot aab97ffee0 SPIGOT-6220: Structures in the world with custom generator not work
By: DerFrZocker <derrieple@gmail.com>
2021-08-01 08:26:30 +10:00
CraftBukkit/Spigot fa9a064a7d Increase outdated build delay
By: md_5 <git@md-5.net>
2021-07-30 19:11:09 +10:00
CraftBukkit/Spigot af0d8b70df SPIGOT-6678: ChunkSnapshot#isSectionEmpty() not working as intended.
By: DerFrZocker <derrieple@gmail.com>
2021-07-27 18:07:14 +10:00
CraftBukkit/Spigot eda6555bbf #901: Fix PlayerStatisticIncrementEvent spam
By: Mitchell Sulkowski <mitchellsulkowski@gmail.com>
2021-07-26 19:32:51 +10:00
CraftBukkit/Spigot e4b545e047 Only remove tile entity if block type changes
By: md_5 <git@md-5.net>
2021-07-24 07:55:52 +10:00
CraftBukkit/Spigot 353c9f5090 SPIGOT-1753: ChunkGenerator lighting updates
By: DerFrZocker <derrieple@gmail.com>
2021-07-23 16:43:53 +10:00
CraftBukkit/Spigot f294d260b8 SPIGOT-6666: NPE when deserializing bundle
By: md_5 <git@md-5.net>
2021-07-23 16:38:51 +10:00
CraftBukkit/Spigot 93f615157d #893: Add Crafting methods to API
By: James Peters <jameslfc19@gmail.com>
2021-07-22 11:35:48 +10:00
CraftBukkit/Spigot 0376264d06 Fix missing varargs from previous commit
By: md_5 <git@md-5.net>
2021-07-22 11:30:14 +10:00
CraftBukkit/Spigot bacb1b57f1 SPIGOT-6641: Use varargs in sendMessage
By: md_5 <git@md-5.net>
2021-07-22 09:54:57 +10:00
CraftBukkit/Spigot 2ccd460e09 SPIGOT-6663: Chicken Jockeys chickens don't despawn
By: md_5 <git@md-5.net>
2021-07-22 09:53:26 +10:00
CraftBukkit/Spigot bfc74e8628 SPIGOT-6545: Unable to set Guardian target via API while awareness is disabled
By: DerFrZocker <derrieple@gmail.com>
2021-07-22 09:36:54 +10:00
CraftBukkit/Spigot 1e8509d8ef SPIGOT-3725, SPIGOT-6638, MC-136917: Properly clear tile entities before replacing
By: DerFrZocker <derrieple@gmail.com>
2021-07-19 18:49:27 +10:00
CraftBukkit/Spigot 71d4016a4d #891: Fix scheduler task ID overflow and duplication issues
By: Phoenix616 <max@themoep.de>
2021-07-17 11:39:56 +10:00
CraftBukkit/Spigot c1484dc4b1 #890: Include yaw in player's spawn location
By: Phoenix616 <max@themoep.de>
2021-07-15 20:29:38 +10:00
CraftBukkit/Spigot 96eed49699 #889: Fix CraftChest close() sound being replaced with open sound.
By: James Peters <jameslfc19@gmail.com>
2021-07-15 20:29:38 +10:00
CraftBukkit/Spigot e797fdd58a #886: Add new Causes for LightningStrikeEvent
By: Doc <nachito94@msn.com>
2021-07-13 19:16:36 +10:00
CraftBukkit/Spigot cae78fadd8 SPIGOT-6579: DragonFireBall movement with setDirection jumps around a lot
By: DerFrZocker <derrieple@gmail.com>
2021-07-11 09:34:35 +10:00
CraftBukkit/Spigot 02134e4ee6 SPIGOT-6634: Override needed method
By: DerFrZocker <derrieple@gmail.com>
2021-07-09 23:48:16 +10:00
CraftBukkit/Spigot e8c9836ec9 Update to Minecraft 1.17.1
By: md_5 <git@md-5.net>
2021-07-07 00:00:00 +10:00
CraftBukkit/Spigot 0392f45e9c Remove outdated build delay.
By: md_5 <git@md-5.net>
2021-07-06 22:16:50 +10:00
CraftBukkit/Spigot 0c2fdaf521 SPIGOT-6527: Add AxolotlBucketMeta
By: Doc <nachito94@msn.com>
2021-07-04 09:32:25 +10:00
CraftBukkit/Spigot a388fc3a6c Update Maven plugins
By: md_5 <git@md-5.net>
2021-07-03 11:06:33 +10:00
CraftBukkit/Spigot bc5ed0e911 SPIGOT-6616: Cancellable StriderTemperatureChangeEvent
By: md_5 <git@md-5.net>
2021-07-03 09:36:51 +10:00
CraftBukkit/Spigot fec9294c47 SPIGOT-6615 Fix Glow Item Frame to use EntityTagMeta
By: Doc <nachito94@msn.com>
2021-07-03 09:33:04 +10:00
CraftBukkit/Spigot 80472fd082 SPIGOT-6605: Add method to access value of enforce-whitelist
By: md_5 <git@md-5.net>
2021-06-26 09:58:34 +10:00
CraftBukkit/Spigot ae7ed4667b SPIGOT-6594: NPE at Bukkit.getServer().getGenerateStructures()
By: md_5 <git@md-5.net>
2021-06-24 08:37:58 +10:00
CraftBukkit/Spigot a91dc63398 #872: SculkSensor accesses underlying TileEntity instead of snapshot for vibration frequency.
By: blablubbabc <lukas@wirsindwir.de>
2021-06-23 09:02:10 +10:00
CraftBukkit/Spigot 26fd70263e SPIGOT-6592: Tile entities in custom ChunkGenerator causes crash
By: md_5 <git@md-5.net>
2021-06-21 08:46:23 +10:00
CraftBukkit/Spigot 46a09d53f1 #870: Add isTrusting/setTrusting to CraftOcelot.
By: Ibrahim Ansari <ansari.ibrahim1@gmail.com>
2021-06-21 08:40:43 +10:00
CraftBukkit/Spigot 690c8b65a1 SPIGOT-6587: Update documentation/error of drop chance API
By: md_5 <git@md-5.net>
2021-06-20 12:15:28 +10:00
CraftBukkit/Spigot 66df1397b3 Fix Inventory#getViewers on the player inventory not returning the player first time their inventory is opened
By: md_5 <git@md-5.net>
2021-06-20 09:27:32 +10:00
CraftBukkit/Spigot d2c0fcf0df #869: Fix BossBar setColor and setStyle updates
By: Eric Su <ericsu14@hotmail.com>
2021-06-17 17:37:30 +10:00
CraftBukkit/Spigot 0747934cc1 Incrase outdated build delay
By: md_5 <git@md-5.net>
2021-06-17 08:42:37 +10:00
CraftBukkit/Spigot 4b86eeff64 SPIGOT-6570: Missing InventoryType: COMPOSTER
By: md_5 <git@md-5.net>
2021-06-17 08:29:15 +10:00
CraftBukkit/Spigot b9782609ca SPIGOT-6558: Attempt to improve SkullMeta
By: md_5 <git@md-5.net>
2021-06-16 10:28:42 +10:00
CraftBukkit/Spigot 9233fd67b4 Fix duplicate datapack reload on /reload
By: md_5 <git@md-5.net>
2021-06-15 15:51:13 +10:00
CraftBukkit/Spigot 6b435994e8 SPIGOT-6555: Cannot access shield BlockStateMeta
By: md_5 <git@md-5.net>
2021-06-15 13:06:23 +10:00
CraftBukkit/Spigot 752618d75f SPIGOT-6560: Crash when falling stalactite hits player
By: md_5 <git@md-5.net>
2021-06-15 08:01:07 +10:00
CraftBukkit/Spigot 46c18bc4d5 #865: Implement Villager#shakeHead
By: VendoAU <reillyreaby@gmail.com>
2021-06-14 19:13:37 +10:00
CraftBukkit/Spigot 8777dd8e62 #863: Add LivingEntity#isClimbing
By: Martoph <sager1018@gmail.com>
2021-06-14 19:11:46 +10:00
CraftBukkit/Spigot 733b118606 SPIGOT-6554: Worlds created with the bukkit ChunkGenerator cannot save
By: md_5 <git@md-5.net>
2021-06-14 13:52:25 +10:00
CraftBukkit/Spigot 967b0303f3 SPIGOT-6507: Implement abstract skeleton and stray conversion
The previous layout and class hierarchy of the skeleton API defined
variances of the skeleton, such as the wither skeleton or the stray, as
child types of the normal skeleton variance, which is technically
incorrect, yet did not produce any specific issue as the normal skeleton
variance did not have any unique logic.

With the introduction of powdered snow in the 1.17 update, the normal
skeleton variance now has unique logic, specifically the conversion to
a stay when stuck inside powdered snow, which cannot be represented in
the current API layout due to the prior mentioned hierarchy.

This commit implements the hierarchy changes made in the bukkit
repository by representing the new hierarchy on the craftbukkit side
through the CraftAbstractSkeleton and the respective additions to the
skeleton implementation in regards to the stray conversion.

This commit does not break ABI yet breaks backwards compatibility due to
the mentioned hierarchy changes. Plugins that previously used the
Skelton interface to compute whether or not an entity is skeleton-like
through instanceOf checks will now only match the normal skeleton variance
instead of any skeleton-like entity.

By: Bjarne Koll <lynxplay101@gmail.com>
2021-06-14 10:01:19 +10:00