Commit Graph

2659 Commits

Author SHA1 Message Date
Aikar 3b63ba9db1 Thread Safe Vanilla Command permission checking
Datapacks check this on load and are built concurrently. This was breaking them badly due
to race conditions.

Plus, .canUse we want to be safe for async anyways.

Fixes #3722
2020-07-11 03:55:59 -04:00
BillyGalbreath 5f0de8fc57 Fix MC-125757 (#3859) 2020-07-09 19:40:37 -05:00
Aikar 3ccbdd3c85 Only convert lore lines that actually look legacy
Spigot stored previous componenents as new ChatComponentText("legacy codes") which
this patch aimed to convert to the new format.

However, the impl ended up converting all lines.

If a plugin had a section symbol in the lore that isn't a color conversion, it would
make trigger this process every single time.

So now we will only process it if the pattern looks like the legacy bukkit format

Fixes #3869
2020-07-09 20:31:04 -04:00
Aikar 8b5bb0dbe0 Misc Improvements to Async Teleporting and Light patch
Stop light copy was missing a default in the impl.
Should of been extremely low chance of impacting anything though
as the very first copy operation would have fixed it.

Sadly this doesn't fix the issues weve been trying to fix.

Fix player async teleporting adding priority to wrong world for cross world teleports

Also improve teleporting to wait for entity ticking status before teleporting to prevent neighbors loading
2020-07-09 19:24:10 -04:00
Automated 7c7443c1bd [Auto] Updated Upstream (CraftBukkit)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
72f368909 SPIGOT-5965: BlockRedstoneEvent.setNewCurrent(0) crashes server
60f8a29d1 SPIGOT-5968: Killer rabbits can't be set to the non-killer rabbit behavior
69fddc725 #705: Improve implementation of furnace related block states
2020-07-08 19:17:08 -04:00
Mariell 4455020aa4 Fix Villagers WeightedList issue (#3860)
dont clone the list for villagers as the list is accessed post sort and needs to have sorted data.
2020-07-08 21:57:24 +02:00
Aikar aa9c5663ec Fix bug on y bitset extraction from 1.16 update
accidently copied z's to y.

seems to impact light only, but is not the source of the light bug we've been trying to fix
2020-07-07 01:41:02 -04:00
Wyatt Childers 81f9964fcb Optimize the advancement data player iteration to be O(N) rather than O(N^2) 2020-07-04 23:08:23 -04:00
Automated 386cb1c1c9 [Auto] Updated Upstream (CraftBukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
2f1810812 Improve physics code

Spigot Changes:
c3a49df2 Rebuild patches
2020-07-06 19:47:11 -04:00
Aikar bf940a42e0 Fix Concurrency issue in WeightedList
if multiple threads from worldgen sort at same time, it will crash.
So make a copy of the list for sorting purposes.

Fixes #3732
Fixes #3824
2020-07-06 18:38:10 -04:00
Andrew Steinborn 7a714e6e13 [1.16] Optimize NetworkManager exception handling (#3819) 2020-07-06 00:27:37 -04:00
Aikar 7f78e35522 Fire inventory listeners if PrepareResult changes item
Fixes #3810
2020-07-05 15:33:23 -04:00
Aikar 130bffdf85 Don't check chunk for portal on world gen entity add - Fixes #3780 2020-07-05 15:00:07 -04:00
BillyGalbreath 3aa6d3b3c0 Implements #3761 - Add entity liquid API (#3762) 2020-07-05 02:00:09 -05:00
Aikar 174560824a Fix anvils bug - Fixes #3802 2020-07-05 02:25:29 -04:00
Aikar 1e75e54195 Move bedrock config under unsupported, add comments to these configs
Hopefully help 'technical minecrafters' find and understand these configs
by adding notes to them, and fixing the incorrect config placement on the
bedrock config.
2020-07-05 02:12:14 -04:00
MiniDigger | Martin 149172d006 Allow delegation to vanilla chunk gen 2020-04-29 02:12:51 +02:00
MiniDigger | Martin 4cb36133b6 Allow delegation to vanilla chunk gen 2020-04-29 02:12:51 +02:00
BillyGalbreath b7c653f532 Add PrepareResultEvent (#3776)
Adds a new event for all crafting stations that generate a result slot item

Anvil and Grindstone now extend this event
2020-07-04 22:36:46 -05:00
BillyGalbreath 3de79cd7c3 Report proxy onlinde mode to bstats as online (#3093) 2020-07-04 21:59:25 -05:00
William Blake Galbreath 2ce563b6d0 Fix #3701 - Loottables erasing on viewing 2020-07-02 15:34:26 -05:00
Jake Potrebic 5064606627 Incorrect spawn reason for monsters from spawner - Fixes #3708 (#3764) 2020-07-04 19:54:39 -06:00
Josh Roy 0ad44580b3 Remove streams from classes related to villager gossip (#3748) 2020-07-04 21:31:58 -04:00
Jake Potrebic bbf35c13bb add EntityTargetLivingEntityEvent for new 1.16 mobs (#3782) 2020-07-04 19:30:13 -06:00
BillyGalbreath 7de9b9d112 Update itemstack legacy name and lore (#3741) 2020-07-04 19:47:24 -05:00
Automated 27e5ecf06c [Auto] Updated Upstream (CraftBukkit)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
833047174 Increase outdated build delay to 7 days
5209a4f73 SPIGOT-5940: EntityChangeBlockEvent is not called for villager emptying composter
2020-07-04 19:02:13 -04:00
Wyatt Childers 9fd4674a11 Spawn player in correct world on login 2020-07-03 14:57:28 -04:00
Aikar d1261a7551 Support String UUID's in old player skulls
Should fix remaining skull issues for people with unconverted old skulls.

Fixes #3734
2020-07-03 02:16:51 -04:00
Aikar d6e23b14a7 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
0ca45a21 #503: Add PlayerHarvestBlockEvent
dfa80a52 SPIGOT-5930: Add PlayerRespawnEvent#isAnchorSpawn

CraftBukkit Changes:
145921e2 #676: Add PlayerHarvestBlockEvent
47abffa2 SPIGOT-5929: Angered zombified piglins do not inherit killed_by_player status
7f6b4f58 SPIGOT-5930: Add PlayerRespawnEvent#isAnchorSpawn
94eff632 SPIGOT-5867, MC-193339: NPE during shutdown when rcon enabled with no password
068618eb SPIGOT-5927: Some items NBT data disappears

Spigot Changes:
beb7d47c Rebuild patches

Fixes #3738
2020-07-03 02:08:00 -04:00
Jake Potrebic 0740b03bab Bandaid italic legacy serialization #3757 (#3760) 2020-07-02 15:42:23 -06:00
MiniDigger | Martin cbc2d143d7 Support components in ItemMeta (#3513) 2020-07-02 17:53:21 +02:00
Callum c09194971e Fix MOTD new line support (#3756) 2020-07-02 13:58:39 +01:00
Callum 85408c2f74 Fix hex colours not being allowed in MOTD (#3755) 2020-07-02 08:19:43 +01:00
Automated 0f6675fffa [Auto] Updated Upstream (CraftBukkit)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
d9bd43b06 Change outdated build delay to 3 days
2020-07-01 19:17:11 -04:00
Josh Roy a03c4deb10 [1.16] Remove some streams from structures (#3704)
This showed up a lot in the spark profiler, should have a low-medium performance improvement.
2020-07-01 09:53:16 -04:00
Shane Freeder 3bc3b61ce3 Fix shutdown on eula not being agreed (Fixes #4647) 2020-07-01 12:21:57 +01:00
Aikar e32b8cfddb Improve old UUID support, clean up old legacy keys.
If we set a UUID to new format, need to make sure old format doesn't
exist anymore. Additionally, ensure if new format exists, we prefer it over old.
2020-07-01 05:42:51 -04:00
Aikar 62802db4ac Allow teleporting through end gateways as a passenger/vehicle
Vanilla allows this now for same world teleports

Fixes #3735
2020-07-01 05:42:22 -04:00
Aikar be5f765e93 Convert legacy attributes in Item Meta
Fixes #3705
2020-07-01 04:28:56 -04:00
Aikar 7b5d35ff25 Fix server not stopping when eula not agreed yet 2020-07-01 03:32:26 -04:00
Aikar 438da20dd5 Clean up duplicated GameProfile Properties
We had a bug where we accidently cloned properties resulting in skulls
growing to large sizes and preventing login.

This now automatically cleans up the extra properties.

Fixes #3719
Fixes #3667
2020-07-01 03:15:52 -04:00
Aikar d9bdfa4aa2 Fix supporting more places of the old UUID format
Fixes #3734
2020-07-01 03:13:57 -04:00
Aikar 174c81a963 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
6ff65c82 SPIGOT-5908: CompassMeta for new lodestone compass data

CraftBukkit Changes:
3b9cf0f8 Improve code formatting
008f039f SPIGOT-5913: MOTD no longer supports new line character
b8b65eb7 SPIGOT-5908: CompassMeta for new lodestone compass data

Spigot Changes:
4d9262cf Rebuild patches
d27f7952 SPIGOT-5912: Outdated client message shows outdated server message
2020-07-01 02:11:46 -04:00
Aikar 860f4c4b58 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
42d5a714 SPIGOT-5899: Hoglins API similar to Piglins
2c1ee10e SPIGOT-5887: ClickType doesn't include off hand swaps
5ff7c7ce SPIGOT-5886: Missing BlockData

CraftBukkit Changes:
7560f5f5 SPIGOT-5905: Fix hex colours not being allowed in MOTD
d47c47ee SPIGOT-5889: Villager using composter should call EntityChangeBlockEvent
2fe6b4a3 SPIGOT-5899: Hoglins API similar to Piglins
e09dbeca SPIGOT-5887: ClickType doesn't include off hand swaps
23aac2a5 SPIGOT-5903: EntityDismountEvent cannot be triggered asynchronously
92cbf656 SPIGOT-5884: Tab completions lost on reloadData / minecraft:reload
fb4e54ad SPIGOT-5902: PlayerRespawnEvent places player at spawn before event is called
aa8f3d5a SPIGOT-5901: Structures are generated in all worlds based on the setting for the main world
a0c35937 SPIGOT-5895: PlayerChangedWorldEvent#getFrom is incorrect
89c0a5c3 SPIGOT-5886: Missing BlockData

Spigot Changes:
0287a20d SPIGOT-5903: EntityDismountEvent cannot be triggered asynchronously
2020-06-30 01:20:29 -04:00
Shane Freeder d2d7dfbef2 Fix compile 2020-06-29 15:03:41 +01:00
Shane Freeder d84b4a3b26 fix EntityDismountEvent being fired on gen threads 2020-06-29 14:48:24 +01:00
Aikar 849ede2317 Don't fire unleash/dismount events from worldgen threads
Mojang can trigger this during worldgen and tries to fire bukkit events.
2020-06-29 04:04:18 -04:00
Aikar b94e847258 Support old UUID format for NBT
We have stored UUID in plenty of places that did not get DFU'd

So just look for old format and load it if it exists.
2020-06-29 03:28:10 -04:00
Aikar c4520e6199 Improve Legacy Component serialization size
Don't constantly send format: false for all formatting options when parent already
has it false

Fixes #3680
2020-06-28 21:27:16 -04:00
Aikar 8e46a01608 Fix case where some skulls still have string UUID's
These heads are technically outdated, but this patch shouldn't care about
what format the original value was in, so keep it the same.
2020-06-28 20:33:14 -04:00