Co-authored-by: Bjarne Koll <git@lynxplay.dev> Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com> Co-authored-by: Lulu13022002 <41980282+Lulu13022002@users.noreply.github.com> Co-authored-by: MiniDigger | Martin <admin@minidigger.dev> Co-authored-by: Nassim Jahnke <nassim@njahnke.dev> Co-authored-by: Noah van der Aa <ndvdaa@gmail.com> Co-authored-by: Owen1212055 <23108066+Owen1212055@users.noreply.github.com> Co-authored-by: Shane Freeder <theboyetronic@gmail.com> Co-authored-by: Spottedleaf <Spottedleaf@users.noreply.github.com> Co-authored-by: Tamion <70228790+notTamion@users.noreply.github.com> Co-authored-by: Warrior <50800980+Warriorrrr@users.noreply.github.com>
70 lines
4.0 KiB
Diff
70 lines
4.0 KiB
Diff
--- a/net/minecraft/world/level/BlockGetter.java
|
|
+++ b/net/minecraft/world/level/BlockGetter.java
|
|
@@ -33,6 +_,17 @@
|
|
|
|
BlockState getBlockState(BlockPos pos);
|
|
|
|
+ // Paper start - if loaded util
|
|
+ @Nullable BlockState getBlockStateIfLoaded(BlockPos pos);
|
|
+
|
|
+ default @Nullable net.minecraft.world.level.block.Block getBlockIfLoaded(BlockPos pos) {
|
|
+ BlockState type = this.getBlockStateIfLoaded(pos);
|
|
+ return type == null ? null : type.getBlock();
|
|
+ }
|
|
+
|
|
+ @Nullable FluidState getFluidIfLoaded(BlockPos pos);
|
|
+ // Paper end
|
|
+
|
|
FluidState getFluidState(BlockPos pos);
|
|
|
|
default int getLightEmission(BlockPos pos) {
|
|
@@ -66,10 +_,25 @@
|
|
);
|
|
}
|
|
|
|
- default BlockHitResult clip(ClipContext context) {
|
|
- return traverseBlocks(context.getFrom(), context.getTo(), context, (traverseContext, traversePos) -> {
|
|
- BlockState blockState = this.getBlockState(traversePos);
|
|
- FluidState fluidState = this.getFluidState(traversePos);
|
|
+ // CraftBukkit start - moved block handling into separate method for use by Block#rayTrace
|
|
+ default BlockHitResult clip(ClipContext traverseContext, BlockPos traversePos) {
|
|
+ // Paper start - Add predicate for blocks when raytracing
|
|
+ return clip(traverseContext, traversePos, null);
|
|
+ }
|
|
+
|
|
+ default BlockHitResult clip(ClipContext traverseContext, BlockPos traversePos, @Nullable java.util.function.Predicate<? super org.bukkit.block.Block> canCollide) {
|
|
+ // Paper end - Add predicate for blocks when raytracing
|
|
+ // Paper start - Prevent raytrace from loading chunks
|
|
+ BlockState blockState = this.getBlockStateIfLoaded(traversePos);
|
|
+ if (blockState == null) {
|
|
+ // copied the last function parameter (listed below)
|
|
+ Vec3 vec3d = traverseContext.getFrom().subtract(traverseContext.getTo());
|
|
+
|
|
+ return BlockHitResult.miss(traverseContext.getTo(), Direction.getApproximateNearest(vec3d.x, vec3d.y, vec3d.z), BlockPos.containing(traverseContext.getTo()));
|
|
+ }
|
|
+ // Paper end - Prevent raytrace from loading chunks
|
|
+ if (blockState.isAir() || (canCollide != null && this instanceof LevelAccessor levelAccessor && !canCollide.test(org.bukkit.craftbukkit.block.CraftBlock.at(levelAccessor, traversePos)))) return null; // Paper - Perf: optimise air cases & check canCollide predicate
|
|
+ FluidState fluidState = blockState.getFluidState(); // Paper - Perf: don't need to go to world state again
|
|
Vec3 from = traverseContext.getFrom();
|
|
Vec3 to = traverseContext.getTo();
|
|
VoxelShape blockShape = traverseContext.getBlockShape(blockState, this, traversePos);
|
|
@@ -79,6 +_,18 @@
|
|
double d = blockHitResult == null ? Double.MAX_VALUE : traverseContext.getFrom().distanceToSqr(blockHitResult.getLocation());
|
|
double d1 = blockHitResult1 == null ? Double.MAX_VALUE : traverseContext.getFrom().distanceToSqr(blockHitResult1.getLocation());
|
|
return d <= d1 ? blockHitResult : blockHitResult1;
|
|
+ }
|
|
+ // CraftBukkit end
|
|
+
|
|
+ default BlockHitResult clip(ClipContext context) {
|
|
+ // Paper start - Add predicate for blocks when raytracing
|
|
+ return clip(context, (java.util.function.Predicate<org.bukkit.block.Block>) null);
|
|
+ }
|
|
+
|
|
+ default BlockHitResult clip(ClipContext context, @Nullable java.util.function.Predicate<? super org.bukkit.block.Block> canCollide) {
|
|
+ // Paper end - Add predicate for blocks when raytracing
|
|
+ return (BlockHitResult) BlockGetter.traverseBlocks(context.getFrom(), context.getTo(), context, (raytrace1, blockposition) -> {
|
|
+ return this.clip(raytrace1, blockposition, canCollide); // CraftBukkit - moved into separate method // Paper - Add predicate for blocks when raytracing
|
|
}, failContext -> {
|
|
Vec3 vec3 = failContext.getFrom().subtract(failContext.getTo());
|
|
return BlockHitResult.miss(failContext.getTo(), Direction.getApproximateNearest(vec3.x, vec3.y, vec3.z), BlockPos.containing(failContext.getTo()));
|