From 49e2988e3745d1aa015855ce64428a09c56a958a Mon Sep 17 00:00:00 2001 From: Andrew Steinborn Date: Fri, 8 Aug 2025 21:47:49 -0400 Subject: [PATCH] Utilize `ByteBuf.readString()` --- .../java/com/velocitypowered/proxy/protocol/ProtocolUtils.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java b/proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java index a90ee9dc..5b54e0f0 100644 --- a/proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java +++ b/proxy/src/main/java/com/velocitypowered/proxy/protocol/ProtocolUtils.java @@ -279,8 +279,7 @@ public enum ProtocolUtils { checkFrame(buf.isReadable(length), "Trying to read a string that is too long (wanted %s, only have %s)", length, buf.readableBytes()); - String str = buf.toString(buf.readerIndex(), length, StandardCharsets.UTF_8); - buf.skipBytes(length); + String str = buf.readString(length, StandardCharsets.UTF_8); checkFrame(str.length() <= cap, "Got a too-long string (got %s, max %s)", str.length(), cap); return str; }