Commit Graph

1031 Commits

Author SHA1 Message Date
Andrew Steinborn 0debb81392 I was nagged to make it more consistent 2021-05-03 20:08:16 -04:00
Andrew Steinborn 0811ebb312 Gotta add the license header to the test file 2021-05-03 19:18:06 -04:00
Andrew Steinborn 4ca97a6df9 Reapply "Optimize varint writing"
Inspired by the approach described at the bottom of https://richardstartin.github.io/posts/dont-use-protobuf-for-telemetry

Given that we do a lot of varint writing as well, this should provide a small performance boost for larger/complex packets whilst not regressing hard on smaller packets.

This includes a test to ensure that the behavior is as expected and fixes the initialization loop so that the correct results will be given. Much thanks to @octylFractal for acting as my duck while trying to figure this out.
2021-05-03 19:14:48 -04:00
Andrew Steinborn e531cdb373 Revert "Optimize varint writing"
This reverts commit 3db2fe8d63.
2021-05-03 18:07:25 -04:00
Andrew Steinborn 3db2fe8d63 Optimize varint writing
Inspired by the approach described at the bottom of https://richardstartin.github.io/posts/dont-use-protobuf-for-telemetry

Given that we do a lot of varint writing as well, this should provide a small performance boost for larger/complex packets whilst not regressing hard on smaller packets.
2021-05-03 17:31:32 -04:00
Andrew Steinborn 347853b945 Disable hinting test for now 2021-04-25 10:18:58 -04:00
Andrew Steinborn 81311e7516 Don't attempt to decode empty buffers (fixes #482)
Stuff like this makes me want to drop support for <=1.13 versions of Minecraft.
2021-04-25 10:14:13 -04:00
Andrew Steinborn ce26ae76c2 Fix case-sensitivity for ping passthrough 2021-04-22 11:23:42 -04:00
Andrew Steinborn ca52f8989e Load forced hosts as lowercase too, see #464 2021-04-18 08:22:36 -04:00
Andrew Steinborn ff54622663 Forced hosts should be case-insensitive. Fixes #464 2021-04-18 08:20:04 -04:00
Andrew Steinborn f1cb3eb1a2 Move timeout handler to after frame decoder
Mitigates attacks like the one described in SpigotMC/BungeeCord#3066. This cannot be considered a full protection, only a mitigation that expects full packets. The attack described is essentially the infamous Slowloris attack.
2021-04-15 22:56:37 -04:00
Andrew Steinborn c51359e893 Move away from deprecated percent() method.
Also fixed another small nit.
2021-04-15 04:23:59 -04:00
Andrew Steinborn 4de71fe942 Fix color and overlay packets for Adventure boss bar
Someone discovered this bug but decided not to tell anyone. For the record, I'm the one who was brain-damaged... well, I made that particular copy-paste error.
2021-04-15 04:22:44 -04:00
Cubxity 5ea6728d1a Added ListenerBoundEvent and ListenerCloseEvent. (#454) 2021-04-02 13:24:45 -04:00
Rocco c34aee76ae Fix Forge/Client Proxy Connections mismatch in config (#456) 2021-04-02 12:36:32 -04:00
A248 7ba2318506 Fix one more case of a possibly swallowed exception (#455)
Maybe spotbugs will add a rule for this in the future
2021-04-02 01:45:58 -04:00
Andrew Steinborn c747120b20 Relicense the Velocity proxy under the terms of GPLv3 (#448) 2021-03-31 16:04:06 -04:00
Andrew Steinborn 514115a85c Do not use an ASCII string for handshake 2021-03-30 12:10:55 -04:00
Andrew Steinborn f88283f127 Revert "Revert strict handshake hostname checks"
This reverts commit 4f80d2b261.

Experience elsewhere (Waterfall PR) and confirmation from TCPShield means
this ought to work. Let's hope.
2021-03-30 12:08:08 -04:00
Andrew Steinborn 8aad6e2ece clear input buffer in case of bad varints 2021-03-30 12:05:43 -04:00
Andrew Steinborn 0cc300b621 don't swap these two around 2021-03-23 07:38:07 -04:00
Andrew Steinborn 3111816545 Warn about null permission functions. 2021-03-23 07:32:01 -04:00
A248 0016f4ce19 Relay more exceptions (#446) 2021-03-22 08:11:25 -04:00
Andrew Steinborn 72d47b5a3d Don't advertise the BungeeCord plugin messaging channel if it is disabled. 2021-02-18 18:12:51 -05:00
David Mayr 648624d333 Check permissions before providing suggestions (#430) 2021-02-16 19:13:48 -05:00
Andrew Steinborn b94303d2be Map command nodes being serialized by their identities
Fixes #429
2021-02-16 01:14:22 -05:00
Bastian 7a713e9379 Update bStats and migrate to new config file
This commit simplifies the Metrics class by using the new base module
from bStats. It also migrates to the new bStats config file that will
be used by plugins that integrate bStats. If a user disabled bStats in
the old config file, this setting will be copied to the new config file.
2021-02-12 20:29:07 +01:00
Camotoy fb879cb498 Apply initial requested changes 2021-02-09 14:13:33 -05:00
Camotoy d47b339908 Add PlayerPluginMessageRegisterEvent 2021-02-09 13:51:43 -05:00
Andrew Steinborn 7e42c5b2e7 Turn some APIs into no-ops if they apply to clients without the relevant client functionality. 2021-02-07 15:19:59 -05:00
Andrew Steinborn b88c573eb1 Correctly forward the player's virtual host to the remote server. 2021-02-01 16:17:02 -05:00
Andrew Steinborn 4f80d2b261 Revert strict handshake hostname checks
These will break TCPShield and Cosmic Guard plugins. Sad as this was a worthwhile mitigation.
2021-01-29 23:08:14 -05:00
Andrew Steinborn 501853e807 Fix Checkstyle issue for the umpteenth time... 2021-01-29 17:59:00 -05:00
Andrew Steinborn 4f6d238b39 Strictly limit the hostname size and limit it to ASCII characters only 2021-01-29 17:56:50 -05:00
Andrew Steinborn 4219bf7b09 *Actually* fix Checkstyle issues 2021-01-26 20:02:07 -05:00
Andrew Steinborn b982c5b6ed Fix Checkstyle issues 2021-01-26 19:59:29 -05:00
Andrew Steinborn 0c90e94e85 fix 2021-01-26 19:50:43 -05:00
Andrew Steinborn 5ceac16a82 Add upfront size checks for some packets.
This is simply a further protection against certain attacks which send malformed packets to the proxy.
2021-01-26 12:33:35 -05:00
Andrew Steinborn 959e75d16d Revert "Also provide a "proper" java.util.logger logger to plugins."
This reverts commit 8d71ea7135.

Totally broken
2021-01-25 09:46:42 -05:00
Andrew Steinborn 8d71ea7135 Also provide a "proper" java.util.logger logger to plugins. 2021-01-25 01:54:50 -05:00
Andrew Steinborn 4bc76b3012 Add JUL support to log4j
Certain badly behaved plugins insist on logging with java.util.logging. Accommodate them.
2021-01-25 01:51:32 -05:00
Andrew Steinborn 68ae92f977 Merge pull request #419 from 0-x-2-2/dev/1.1.0
Use keepalive queue instead of just the last keepalive.
2021-01-23 20:18:14 -05:00
0x22 7aed76ee3d Use keepalive queue instead of just the last keepalive. 2021-01-23 18:35:14 -05:00
Andrew Steinborn 03e9fa79d6 Raise limit on JoinGame NBT reading to 2MiB.
This is required for particularly large mod packs (think All of Fabric 3 for instance).
2021-01-23 12:55:28 -05:00
Andrew Steinborn fcffccf0d8 Fix typo 2021-01-23 01:35:49 -05:00
Andrew Steinborn ce7d1dcb26 A new year, a new color for Velocity! 2021-01-23 01:34:46 -05:00
Andrew Steinborn 892ac6f626 Accept changes to compression treshold on the fly.
Vanilla allows this for some reason, and there has been one case where Velocity's strict behavior has caused a bug. Fix this.
2021-01-21 17:58:09 -05:00
Andrew Steinborn 567a3b2365 Swallow and more usefully log exceptions in scheduler task running. 2021-01-09 16:39:38 -05:00
Andrew Steinborn ba1c1eef64 More clarification 2021-01-06 13:30:57 -05:00
Andrew Steinborn 4df8f70156 Rename proxy-protocol setting to haproxy-protocol to make it clearer this is for HAProxy. 2021-01-06 13:29:30 -05:00