From e1220ff5acd039e013720a6eceeacc1e6881063d Mon Sep 17 00:00:00 2001
From: Chaoscaot <max@maxsp.de>
Date: Tue, 2 Dec 2025 22:35:32 +0100
Subject: [PATCH] Refactor player components: streamline state management and
 improve code readability in PermissionsDropdown, Players, and PrefixDropdown

---
 .../pages/players/PermissionsDropdown.svelte  |  5 ++++
 .../moderator/pages/players/Players.svelte    |  2 +-
 .../pages/players/PrefixDropdown.svelte       | 16 ++++++-----
 .../moderator/pages/players/columns.ts        | 27 ++++++++-----------
 4 files changed, 26 insertions(+), 24 deletions(-)

diff --git a/src/components/moderator/pages/players/PermissionsDropdown.svelte b/src/components/moderator/pages/players/PermissionsDropdown.svelte
index 53eb83a..360b4ac 100644
--- a/src/components/moderator/pages/players/PermissionsDropdown.svelte
+++ b/src/components/moderator/pages/players/PermissionsDropdown.svelte
@@ -28,6 +28,11 @@
     let value = $state(perms);
     let prevValue = $state(perms);
 
+    $effect(() => {
+        value = perms;
+        prevValue = perms;
+    });
+
     function onChange(change: string[]) {
         $permissions.perms.forEach((perm) => {
             if (prevValue.includes(perm) && !change.includes(perm)) {
diff --git a/src/components/moderator/pages/players/Players.svelte b/src/components/moderator/pages/players/Players.svelte
index df8fefe..00795d1 100644
--- a/src/components/moderator/pages/players/Players.svelte
+++ b/src/components/moderator/pages/players/Players.svelte
@@ -47,7 +47,7 @@
     let rows = $state(0);
 
     $effect(() => {
-        $dataRepo.queryPlayers(search || undefined, undefined, undefined, pagination.pageSize, pagination.pageIndex, true, true).then((res) => {
+        $dataRepo.queryPlayers(search || undefined, undefined, undefined, pagination.pageSize, pagination.pageIndex, true, false).then((res) => {
             data = res.entries;
             rows = res.rows;
         });
diff --git a/src/components/moderator/pages/players/PrefixDropdown.svelte b/src/components/moderator/pages/players/PrefixDropdown.svelte
index 3093a80..db2b23f 100644
--- a/src/components/moderator/pages/players/PrefixDropdown.svelte
+++ b/src/components/moderator/pages/players/PrefixDropdown.svelte
@@ -18,16 +18,18 @@
   -->
 
 <script lang="ts">
-    import {Select, SelectContent, SelectItem, SelectTrigger} from "@components/ui/select";
-    import {permissions} from "@stores/stores.ts";
-    import {permsRepo} from "@repo/perms.ts";
+    import { Select, SelectContent, SelectItem, SelectTrigger } from "@components/ui/select";
+    import { permissions } from "@stores/stores.ts";
+    import { permsRepo } from "@repo/perms.ts";
 
-    const {
-        prefix, uuid
-    }: { prefix: string, uuid: string } = $props();
+    const { prefix, uuid }: { prefix: string; uuid: string } = $props();
 
     let value = $state(prefix);
 
+    $effect(() => {
+        value = prefix;
+    });
+
     function onChange(change: string) {
         $permsRepo.setPrefix(uuid, change);
 
@@ -44,4 +46,4 @@
             <SelectItem value={prefix[0]}>{prefix[1].chatPrefix === "" ? "None" : prefix[1].chatPrefix}</SelectItem>
         {/each}
     </SelectContent>
-</Select>
\ No newline at end of file
+</Select>
diff --git a/src/components/moderator/pages/players/columns.ts b/src/components/moderator/pages/players/columns.ts
index 2e8cb85..bbac55e 100644
--- a/src/components/moderator/pages/players/columns.ts
+++ b/src/components/moderator/pages/players/columns.ts
@@ -17,8 +17,8 @@
  *   along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-import type {ColumnDef} from "@tanstack/table-core";
-import type {Player} from "@type/data.ts";
+import type { ColumnDef } from "@tanstack/table-core";
+import type { Player } from "@type/data.ts";
 import { renderComponent } from "@components/ui/data-table";
 import PermissionsDropdown from "@components/moderator/pages/players/PermissionsDropdown.svelte";
 import PrefixDropdown from "@components/moderator/pages/players/PrefixDropdown.svelte";
@@ -36,25 +36,20 @@ export const columns: ColumnDef<Player[]> = [
         accessorKey: "prefix",
         header: "Prefix",
         cell: ({ row }) => {
-            return renderComponent(
-                PrefixDropdown, {
-                    prefix: row.getValue("prefix"),
-                    uuid: row.getValue("uuid"),
-                },
-            );
+            return renderComponent(PrefixDropdown, {
+                prefix: row.getValue("prefix"),
+                uuid: row.getValue("uuid"),
+            });
         },
     },
     {
         accessorKey: "perms",
         header: "Permissions",
         cell: ({ row }) => {
-            return renderComponent(
-                PermissionsDropdown,
-                {
-                    perms: row.getValue("perms"),
-                    uuid: row.getValue("uuid"),
-                },
-            );
+            return renderComponent(PermissionsDropdown, {
+                perms: row.getValue("perms"),
+                uuid: row.getValue("uuid"),
+            });
         },
     },
-];
\ No newline at end of file
+];