Commit Graph

19058 Commits

Author SHA1 Message Date
33411ec0a1 Properly remove UnsafeValues#getDamageEffect 2024-12-28 00:21:27 +01:00
5c7537cb5c Add DamageType RegistryEvent (#11783) 2024-12-28 00:13:27 +01:00
4b893907f6 Fix contextual map renderer memory leak (#11841) 2024-12-27 23:25:02 +01:00
b4051dbff7 Handle disabled vanilla registry values correctly (#11781) 2024-12-27 23:11:26 +01:00
e10dcbf7ca [ci skip] Improve build workflow conditions (#11842)
The goal of the build workflow is split into multiple requirements.
  1. Run on pushes to same repo.
  2. Run on PR open/reopen/syncs from repos that are not the same
     (PRs from the same repo are covered by 1)
  3. Run on labeled PRs that have the build-pr-jar flag.
2024-12-27 22:43:08 +01:00
ca8709b30f Fix more incorrect array nullability annotations (#11836) 2024-12-27 22:24:16 +01:00
13c94e40ad Updated adventure to 4.18.0 (#11809) 2024-12-27 22:04:17 +01:00
326c687047 Fix whack diff from last commit 2024-12-27 13:47:25 +01:00
2b73d1957c More var name fixes 2024-12-27 13:45:04 +01:00
c530c39f4e More var name fixes 2024-12-27 12:31:54 +01:00
a5b8df6674 add tagkey file for entity type (#11832) 2024-12-26 16:49:07 -08:00
953f6f929e Banner pattern registry modification (#11803) 2024-12-26 18:57:34 -05:00
aac246ae29 Expand on entity serialization API (#11807) 2024-12-27 00:08:00 +01:00
0efd3012c9 Fix suggestions for ResourceLocation (#11830) 2024-12-27 00:07:02 +01:00
af2812fb0f For new registry values, allow copying from existing (#11796)
Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-12-26 13:41:15 -08:00
f51aa3e3e1 Fix BlockRedstoneEvent for tripwire hooks (#11791) 2024-12-26 19:42:03 +01:00
a14c06bbd8 fix annotation test for null marked inner classes (#11826) 2024-12-26 10:22:00 -08:00
a8f850a128 temporarily revert OldEnum toString changes (#11829) 2024-12-26 10:11:18 -08:00
c9a904ed17 Fix keepalive logic resetting counter
This would of actually arised in the client being kicked due to sending
bad keepalive packets due to the erronious extra sending of keepalives too
2024-12-26 15:19:56 +00:00
3331805d0b Deprecate #furnace_materials item tag (#11823) 2024-12-26 15:24:02 +01:00
d85d318951 Fix NullPointerException in PlayerInteractEvent#getClickedPosition (#11827)
Fixes a NullPointerException in PlayerInteractEvent#getClickedPosition

Re: https://github.com/EngineHub/CraftBook/issues/1340
2024-12-26 08:41:37 +00:00
3a479eadd7 Add Registry#getTags (#11795) 2024-12-25 19:39:27 -08:00
a07cec16f8 Add effective name to ItemStack (#11770) 2024-12-25 21:56:24 +01:00
140577b762 Fix broken field rename compat for instrument "feel_goat_horn" (#11824) 2024-12-25 12:36:23 -08:00
946314fb58 Remove disableTeleportationSuffocationCheck config (#11822) 2024-12-25 12:20:21 -08:00
763b32d825 Fix framed maps looping through all players in world (#11819) 2024-12-25 12:31:03 +01:00
25cc3d8578 Fix EnchantmentView#setOffers length precondition being flipped (#11818) 2024-12-25 11:08:07 +01:00
d568e175ee Port basic lookAt methods from Player to Entity (#11775) 2024-12-24 23:00:07 +01:00
321d17cc8c [ci skip] Only build PRs on correct label (#11811) 2024-12-24 22:58:10 +01:00
9e2d39cd26 Fix double chest identification (#11812) 2024-12-24 22:57:24 +01:00
b8a0541ccf Fix 0 parameter in Player#applyMending (#11802)
Prevent division by zero in Player#applyMending by simply using zero
instead if the divider itself is zero.
This matches vanilla behaviour in the sense that
ExperienceOrb#repairPlayerItems, which this logic is lifted from, does
pass zero to the enchantment helper and runs its first iteration on
repairing. Vanilla is not affected as the computation failing with zero
is used to compute the leftover exp value, which is not needed if zero
itself is passed in.
As the paper impl however exposes said value to the initial event, our
code needs to account for the zero division.
2024-12-24 10:58:58 +01:00
d0d0efee02 Partially revert 083c083188 for Transformation (#11798)
* Partially revert 083c083188 for Transformation

The type is used in a way that requires mutability

* keep copy in ctors
2024-12-23 15:46:17 -08:00
aa2c52baac Fix dropper inventory var 2024-12-23 20:21:31 +01:00
17d76ae42b Correctly die when cancelling EntityResurrectEvent (#11785)
The existing logic in LivingEntity#checkTotemDeathProtection completes
by checking whether the death protection component is null or not.
In cases where the event was cancelled, the component needs to be nulled
out to prevent the method from returning true, causing the player to
properly die.
2024-12-23 19:38:10 +01:00
c76809973b Fix tripwires (#11790) 2024-12-23 19:14:35 +01:00
793d36106d Fix recipe book items order (#11787) 2024-12-23 18:09:12 +01:00
bd4c235c2f Throw during plugin update folder process on failed rename/delete (#11784) 2024-12-23 16:29:28 +01:00
62d4130bba [ci skip] Fix Inventory#addItem javadoc mismatch with behaviour (#11782) 2024-12-23 16:20:12 +01:00
63c94c90d9 [ci skip] Comment out update tasks, update comments 2024-12-23 12:29:27 +01:00
976b0a4d8b [ci skip] Simplify and update contribution guidelines 2024-12-23 12:08:32 +01:00
17f649de1e Fix PlayerTradeEvent visual issue when being cancelled (#11773) 2024-12-23 10:40:04 +01:00
cbf630d5b5 Move missing import into feature patches to fix pre-features compile
Came across this in my complete utter failure to use the commands to
apply patches properly
2024-12-23 09:28:58 +00:00
a0b3326609 refactor registry entry to detach 'delayed' from other meta
Also fixes an issue with direct holders
2024-12-22 21:17:34 -08:00
188124bcc3 Fix totems negating incorrect item (#11776) 2024-12-22 23:58:01 -05:00
f8bf600375 Fix potion effect type removal (#11778)
An incorrectly updated hunk attempted to remove the MobEffectInstance
from the active effect map instead of the Holder<MobEffect> as the
parameter name was changed from holder to effect during hardfork.
2024-12-23 04:51:58 +01:00
eb793c3131 [ci skip] more cleanup from repo reorg 2024-12-22 19:07:17 -08:00
083c083188 Fix a bunch more issues arising from mutable types (#11769) 2024-12-22 22:50:00 +01:00
8ad15d64f0 Update minecraft dir references 2024-12-22 20:50:34 +01:00
90d50aafc5 update .editorconfig 2024-12-22 11:48:32 -08:00
c31d95eccb remove test plugin diff accidentally committed 2024-12-22 11:44:49 -08:00