Commit Graph
100 Commits
Author SHA1 Message Date
Shane Freeder 3f3377a1eb Revert "Legacy data should look for legacy materials (Fixes #6618)" (Fixes #6664)
This reverts commit 3ce522545b.
2021-09-29 03:12:40 +01:00
Shane Freeder 3ce522545b Legacy data should look for legacy materials (Fixes #6618) 2021-09-17 09:35:02 +01:00
Shane Freeder 92c68e2367 Fixup enderpearl patch 2021-09-07 22:33:28 +01:00
Shane Freeder eca2f8fdd0 Fix CocaoDecorator causing a crash during generation (Fixes #6028) 2021-09-07 21:41:54 +01:00
Shane Freeder 20e45f7315 Do not process entity loads in CraftChunk#getEntities (Fixes #6543)
This re-introduces the issue behind #5872 but fixes #6543
The logic here is generally flawed however somewhat of a nuance,
upstream uses managedBlock which is basically needed to process
the posted entity adds, but, has the side-effect of processing any
chunk loads which has the naunce of stacking up and either causing a
massive performance hit, or can potentially lead the server to crash.

This issue is particularly noticable on paper due to the cumulative efforts
to drastically improve chunk loading speeds which means that there is much more
of a chance that we're about to eat a dirtload of chunk load callbacks, thus
making this issue much more of an issue
2021-09-03 15:55:22 +01:00
Shane Freeder 2846c01086 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
6719d1f1 SPIGOT-6708: Fix Experience Orb value not being updated in mend event
2021-09-03 15:43:11 +01:00
Shane Freeder 972fbb74c9 Do not fire PlayerBucketFillEvent when no fluid (Fixes #4611) 2021-08-17 15:43:01 +01:00
Shane Freeder 746d5cb8fb Revert "Revert "Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)""
This reverts commit d2f7432e32.
2021-08-14 15:24:53 +01:00
Shane Freeder d2f7432e32 Revert "Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)"
This reverts commit 701cceb170.
2021-08-14 15:22:21 +01:00
Shane Freeder 701cceb170 Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)
Mojang made some changes to priorities in 1.17 and it seems that these changes
conflict with the changes made in this patch, which in some cases appears to
cause excessive rescheduling of tasks.

This, however, is not confirmed as such but seems to be the behavior that we're
seeing to cause this issue, if mojang has adopted the changes we suggested,
then a good chunk of this patch may be unneeded, but, this needs a much better
look than I'm currently able to do
2021-08-14 14:55:55 +01:00
Shane Freeder 0850e18436 Expose EntityType#getTranslationKey 2021-08-11 06:12:57 +00:00
Shane Freeder c45970a2c1 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
75a0ee4f SPIGOT-6691: Material.LAVA_CAULDRON is not Levelled

CraftBukkit Changes:
e1c96e50 SPIGOT-6682: Blocking with shield not reset after die
97f629b6 SPIGOT-6220: Structures in the world with custom generator not work
85379258 Increase outdated build delay
f7f8dce4 SPIGOT-6552: Some inventory types reset cursor on switch
2021-08-04 16:26:56 +01:00
Shane Freeder 06a831d477 Fix SysoutCatcher when plugins log before initialisation (Fixes #6323) 2021-08-04 04:04:12 +01:00
Shane Freeder b3f290d877 Fix some inconsistency issues with empty map items (#6304) 2021-08-01 16:55:25 +01:00
Shane Freeder 3a17437d6f Mark sensor and behavior timings as verbose 2021-08-01 10:22:55 +01:00
Shane Freeder 38e838b0c9 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
aa69d1cf Only remove tile entity if block type changes
2021-07-24 04:44:04 +01:00
Shane Freeder 87ad9b0502 Fix missing annotation 2021-07-13 19:15:18 +01:00
Shane Freeder 4ca03426b0 Expand resource pack API 2021-07-12 20:42:17 +01:00
Shane Freeder 2143a948be Fix NPE when completing skull lookups without a real owner (Fixes #6052)
This looks like mojang introduced an NPE however it was previously being
supressed by the future used by the server, we'll just stick to the legacy
behavior of retainining the existing profile of earlier versions
2021-07-01 00:10:28 +01:00
Shane Freeder aa1d49efd6 [ci skip] revert dev-imports derp 2021-06-30 22:29:54 +01:00
Shane Freeder 0641643c4a Backport MC-229191 ore distribution changes 2021-06-30 22:11:40 +01:00
Shane Freeder 5a5d27f6a1 Fix NPE when using broadcast as players are joining 2021-06-29 22:21:42 +01:00
Shane Freeder 0e2c1c7288 [ci skip] patch-ception 2021-06-29 17:39:17 +01:00
Shane Freeder 73d13c8c88 Don't complete skull lookups on main thread (MC-227435) 2021-06-29 17:34:20 +01:00
Shane Freeder c203932d0c Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
214b9f14 SPIGOT-6605: Add method to access value of enforce-whitelist

CraftBukkit Changes:
b121d3b9 SPIGOT-6605: Add method to access value of enforce-whitelist
2021-06-29 01:31:35 +01:00
Shane Freeder f3e872c626 Fix players not being added to collide rule (Fixes #6024) 2021-06-28 22:16:46 +01:00
Shane Freeder 65c6d7f38f Drop codec spam fix (Fixes #5936)
having spoken to mojang about this the general issue is data which shouldn't
have been saved in the first place, so if we lose this data it's not really
an issue, bar being annoying spammy. if the spam gets on your nerves, shamefully,
all you can really do is forceUpgrade to get the conversions of the way.

Dropping as this breaks other aspects of the server and bar being spammy
seems to have no other real negative outcomes
2021-06-26 12:56:06 +01:00
Shane Freeder 65a6e249ea Allow explosions under 0 height (Fixes #5974)
Upstream forgot to update the check here which prevents explosions
occuring under 0 height, however, vanilla already checks that we
are in bounds of the world above this, so this call is entirely
redundant.
2021-06-24 01:44:23 +01:00
Shane Freeder b3cf50a134 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
f81f4994 SPIGOT-6594: NPE at Bukkit.getServer().getGenerateStructures()
295ab080 #872: SculkSensor accesses underlying TileEntity instead of snapshot for vibration frequency.
2021-06-24 01:39:30 +01:00
Shane Freeder 5b8a29a0cc Ensure disconnect for book edit is called on main 2021-06-22 20:00:11 +01:00
Shane Freeder 4ad15af215 Fix kick event being fired off main thread 2021-06-22 19:35:35 +01:00
Shane Freeder 1599ffc11d Try even harder to get an origin world and avoid NPEs (Fixes #5931) 2021-06-22 11:54:49 +01:00
Shane Freeder 58c3edcb08 Try to prevent an NPE from origin data (Fixes #5905) 2021-06-21 10:04:18 +01:00
Shane Freeder 1763250105 Fix early load perms patch (Fixes #5917) 2021-06-21 09:41:00 +01:00
Shane Freeder e6193a1630 Add invalid player data to misc debug dumps 2021-06-20 15:06:37 +01:00
Shane Freeder e1116fe452 Modify entity origin API to store world/pos seperatly 2021-06-16 06:36:02 +01:00
Shane Freeder d963592869 Do not tick Chunk TickS for every chunk 2021-06-03 06:13:18 +01:00
Shane Freeder 2614cde313 [CI-SKIP] Fixup patch header 2021-06-02 05:51:15 +01:00
Shane Freeder 11743149cd Restore vanilla water animal limit
Spotted by pheonix616, merged into a similar patch for the sake of
the patch numbers :o
2021-06-02 05:45:12 +01:00
Shane Freeder 51b2370434 Do not print spawn loaded chunks
This counter is no longer accurate due to the fact that paper does not block for these loads
to finish
2021-05-30 03:02:23 +01:00
Shane Freeder a0838b17c2 Revert "Remove itneract event from boat" (Fixes #5677) 2021-05-19 13:38:40 +01:00
Shane Freeder b5488de2ba Revert "Updated Upstream (Bukkit/CraftBukkit/Spigot) (#5636)"
This reverts commit 11c2ef5d2f.
2021-05-15 22:10:57 +01:00
Shane Freeder 084ee854f8 Fix missing CraftMetaBook#toBuilder override 2021-05-06 17:27:19 +01:00
Shane Freeder b9ab5132c3 fix isProxyOnlineMode coverage, don't lookup UUIDs in offline mode (Fixes #2011) 2021-05-05 03:54:42 +01:00
Shane Freeder eccfbfe377 Send empty commands if tab completion is disabled (Closes #5519)
Because this is a trivial fix to an annoying issue people are annoying
about, but, really, stop punishing your players for your own insecurities.
2021-05-05 03:22:32 +01:00
Shane Freeder 2b12d671fa don't throw when loading TE with invalid keys 2021-04-21 20:05:50 +01:00
Shane Freeder 3e0a36dbbd Fix dangling sout 2021-04-18 22:12:09 +01:00
Shane Freeder 3007bdc020 basic hostname validation 2021-04-18 21:47:01 +01:00
Shane Freeder dcdfac1f8c remove l4j class no longer in existence from preload list 2021-04-12 05:16:16 +01:00
Shane Freeder 68f0738631 Properly apply Sign#isEditable to TEs when calling BlockState#update 2021-03-23 06:46:54 +00:00
Shane Freeder eac81f6960 replace spaces in world key (touches #5397) 2021-03-22 01:10:13 +00:00
Shane Freeder 7fb24d323a Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
7eb35643 SPIGOT-6398: Fix crash when bonemealing bamboo and the BlockSpreadEvent is cancelled
2021-03-19 23:27:53 +00:00
Shane Freeder f33a17faf7 Fix creating worlds with "invalid" names (Fixes #5331) 2021-03-09 21:06:09 +00:00
Shane Freeder 5eab69f416 Do not use the bukkit singleton for the GUI (Fixes #5301) 2021-03-04 01:39:18 +00:00
Shane Freeder 1487ee284e Don't grab the threads stacktrace when dumping same thread
For some reason, this doesn't always seem to capture all states of shutdown,
either the logger is just being fun, or, potentially, the thread is already
marked as dead when we're getting called so the trace is not generated through
the method on Thread
2021-02-24 18:45:21 +00:00
Shane Freeder 89e9a596cb Misc thread dumps (#5200) 2021-02-23 21:06:12 +00:00
Shane Freeder 20e500fadc Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
1e843b72 #510: Add NamespacedKey#fromString() to fetch from user input
a4d18241 #581: Add methods to modify despawn delay for wandering villagers

CraftBukkit Changes:
0cd8f19f #802: Add methods to modify despawn delay for wandering villagers
d5c5d998 SPIGOT-6362: ConcurrentModificationException: null --> Server Crash
8c7d69fe SPIGOT-5228: Entities that are removed during chunk unloads are not properly removed from the chunk.
2021-02-16 17:08:29 +00:00
Shane Freeder 777e24e5b5 Deprecate PlayerLeaveBedEvent#setBedSpawn
this is no longer attached to anything, and from a glance it looks like
the point at which this information is set has moved to a place which wouldn't
fall in line in a way that we could re-implement these without breaking vanilla
behaivior

Also, just noticed that we apparently need to give our own javadocs some love
at some point
2021-02-06 22:15:06 +00:00
Shane Freeder 93ff88d6c8 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
e5cb519d #793: Don't unnecessarily toString block in CraftBlockEntityState constructor
2021-02-06 00:02:44 +00:00
Shane Freeder 9c04c8c390 Updated Upstream ()
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing
2021-02-06 00:00:18 +00:00
Shane Freeder c3bd6c65c6 Updated Upstream (Bukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
b94b766f Improve /version command
2021-01-16 02:46:43 +00:00
Shane Freeder 4e38844029 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
85b16b8a Update to Minecraft 1.16.5

CraftBukkit Changes:
f3f30947 Update to Minecraft 1.16.5

Spigot Changes:
018b9a0d Update to Minecraft 1.16.5
2021-01-16 02:18:08 +00:00
Shane Freeder 7d3b9c9bc0 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
7a6c3c9a Remove outdated build delay.
2021-01-15 16:28:53 +00:00
Shane Freeder 2da0e4a287 EntityLoadCrossbowEvent#shouldConsumeItem 2021-01-14 15:53:42 +00:00
Shane Freeder d0d21ba718 Mark PlayerInventory#getItem as nullable 2021-01-14 14:35:50 +00:00
Shane Freeder 8bd708eac7 Move logic from last patch into correct place 2021-01-13 21:31:51 +00:00
Shane Freeder ccd254077b disable entity ticking flag after watchdog obliteration 2021-01-13 21:29:05 +00:00
Shane Freeder 630fa37394 Properly track block update flags (actually fixes #5038) 2021-01-11 19:08:03 +00:00
Shane Freeder 2b06877898 Fix debug stick update suppression (Fixes #5038) 2021-01-11 16:45:37 +00:00
Shane Freeder c92072e21d nerf nether search radius config (#4781) 2021-01-11 01:44:06 +00:00
Shane Freeder 8a917b49f4 clone POI blockpos before dispatching 2021-01-10 18:36:38 +00:00
Shane Freeder 442fa32443 Ensure POI removal occurs on the correct thread 2021-01-09 13:32:26 +00:00
Shane Freeder 3a358f7e70 Remove stale POIs 2021-01-09 14:19:17 +01:00
Shane Freeder bc2999f578 Print name of busted server config files 2021-01-05 11:21:03 +00:00
Shane Freeder 25980711f0 Do not crash from invalid ingredient lists in VillagerAcquireTradeEvent 2020-12-27 11:31:49 +00:00
Shane Freeder 08f196719f Do not perform neighbour updates when using debug stick (Fixes #2134)
CB blindly drops any update flags when recording block modifications,
this causes the debug stick to blindly update neighbouring blocks on usage
in order to control this, we will special case this item, however, this
ideally should be fixed by recording the actual update flags used,
but will induce ABI breaks...

This patch also maintains the behavior of the BlockPlaceEvent, this
behavior will NOT be guaranteed in the future, however.
2020-12-22 22:45:10 +00:00
Shane Freeder 49458cc927 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
6f9fe1d9 #562: Add API to set equipment silently
bcddb754 SPIGOT-6256: Add method to check if the entity is in water

CraftBukkit Changes:
878b4375 #772: Add API to set equipment silently
22d7fcc9 SPIGOT-6256: Add method to check if the entity is in water
2020-12-21 07:56:22 +00:00
Shane Freeder c184de4050 Limit auto recipe packets 2020-12-12 23:53:40 +00:00
Shane Freeder c81621d172 Tick inactive goal selectors 2020-12-09 20:31:08 +00:00
Shane Freeder 2e2d31ae89 Fix keep-spawn-loaded stopping force-loaded chunks from loading
Also, cleanup the patch a little bit
2020-12-01 13:23:44 +00:00
Shane Freeder c74595c473 [CI-SKIP] Misc script changes (Closes #4346)
testserver - use printf instead of echo, as echo is apparently
              inconsistent across environments
requireDeps - change message slightly, maybe more useful to people?
2020-11-29 06:24:39 +00:00
Shane Freeder 41cba04006 Updated Upstream (Bukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
721e678d Fix javadoc in previous commit
2020-11-25 23:58:38 +00:00
Shane Freeder 036bb4e24a Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing
Actually rebuild patches this time...

Bukkit Changes:
19b7b7bd #561: Add clear weather World API
5929c808 #552: Add the ability to retrieve hit, step, fall, and other sounds from blocks.

CraftBukkit Changes:
e1ebdd92 #771: Add clear weather World API
424598d2 #752: Add the ability to retrieve hit, step, fall, and other sounds from blocks.
2020-11-25 23:49:06 +00:00
Shane Freeder 2241a94f70 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
19b7b7bd #561: Add clear weather World API
5929c808 #552: Add the ability to retrieve hit, step, fall, and other sounds from blocks.

CraftBukkit Changes:
e1ebdd92 #771: Add clear weather World API
424598d2 #752: Add the ability to retrieve hit, step, fall, and other sounds from blocks.
2020-11-25 23:45:25 +00:00
Shane Freeder fcd9bc3e26 Updated Upstream (CraftBukkit) (#4760)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
23618b2c SPIGOT-6240: Use correct portal search radius
2020-11-13 22:03:29 +00:00
Shane Freeder e6b2fda436 Revert "Zero pad chunks before saving them to the disk"
This reverts commit dab4c6e16b.
2020-11-13 14:51:22 +00:00
Shane Freeder f7185064c9 Updated Upstream (Spigot)
Restab at the last upstream to add support for migrating the option for disabling player data
saving back into spigots config, vs blindly dropping it

Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Spigot Changes:
a19903d2 SPIGOT-520: Add option to disable player data saving
2020-11-09 01:05:27 +00:00
Shane Freeder fe115b0ebe Revert "Updated Upstream (Spigot) (#4745)"
This reverts commit 27979ca2fa.
2020-11-09 00:09:37 +00:00
Shane Freeder 690a0bc308 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
f4f2ef4c SPIGOT-6222: Correct javadoc for Entity#setPassenger
1871ca9d #559: Add wait time modification for FishHook

CraftBukkit Changes:
bc6a175e #767: Add wait time modification for FishHook
2fc37bcc SPIGOT-6197: Prevent world loading from updating spawn settings of all worlds
2020-11-07 00:19:04 +00:00
Shane Freeder c208709558 Updated Upstream (Bukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
eda400d3 SPIGOT-6213: MinecraftFont.getWidth(" ") returns 2 when it should be 3

Spigot Changes:
aa477927 #100: Allow sending messages from specific UUIDs
2020-11-03 09:14:21 +00:00
Shane Freeder 4d21a2e77a Add support for RanagedEntity API for newer mobs (Fixes #4678) 2020-10-22 13:01:44 +01:00
Shane Freeder f2a3a8db27 Fix SafeNBTCopy#hasKey semantics
Fixes hasKey to check that a key actually exists, while retaining the
option to scream at keys which are requested which haven't been marked as
needing to be copied
2020-10-17 12:46:35 +01:00
Shane Freeder 2942a2d247 Don't assume that entries exist for SafeNBTCopy 2020-10-17 12:20:44 +01:00
Shane Freeder 7391a61447 Revert "Updated Upstream (Bukkit/CraftBukkit/Spigot)"
This reverts commit d833a4aeef.
2020-10-17 10:48:00 +01:00
Shane Freeder d833a4aeef Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
01e22e09 Misc maven build updates
746f5324 #556: Allow sending messages from specific UUIDs
92b99cde #501: Add PersistentDataHolder to Chunk

CraftBukkit Changes:
4ef13f94 Misc maven build updates
04639f5a #759: Allow sending messages from specific UUIDs
77c894a2 #672: Add PersistentDataHolder to Chunk

Spigot Changes:
57bbdd8e Rebuild patches
2020-10-17 09:18:39 +01:00
Shane Freeder 9c1e6eab19 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
ccb9614e #548: LivingEntity - add methods for getting/setting invisibility

CraftBukkit Changes:
f8d4da08 #743: LivingEntity - add methods for getting/setting invisibility

Spigot Changes:
17d78dbd Rebuild patches
2020-09-19 12:29:53 +01:00
Shane Freeder 9cf1088154 Extend block drop capture to capture all items added to the world (Fixes #4307)
Closes #4316
2020-09-17 00:40:00 +01:00
Shane Freeder d45b5f3499 Fix block data exception when cancelling PortalCreateEvent (#4199) 2020-09-10 09:02:22 +01:00
Shane Freeder e233d9a058 install remapped server jar to paper package space
Spigot has been stripping the minecraft-server jar down in order to
reduce it's size, primarily by removing classes they don't use from
fastutil. as we use fastutil and offer it as API, this is useless
to us, and creates headaches when it breaks builds due to spigots
version of this being installed.
2020-09-01 23:20:58 +01:00
Shane Freeder 8dad068601 Updated Upstream (CraftBukkit)
Upstream has released updates that appears to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
3f572834 #740: Fix EntityDamageEvent not being called for non EntityDamageSource for End Crystals
3c7143e7 SPIGOT-5953, SPIGOT-5914: Use LinkedHashMap to keep captured block states in order
2020-08-28 12:06:39 +01:00