Commit Graph
100 Commits
Author SHA1 Message Date
Shane Freeder 8e18842fbc Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
c7c11188 SPIGOT-2620: Add Player#sendBlockChanges()
f63d2b44 Improve annotation test on parameters
3372e7b4 SPIGOT-1244, SPIGOT-6860, SPIGOT-6874: Various Javadoc and formatting fixes
a1e8a9ab PR-793: Ignore .checkstyle file generated by Eclipse IDE

CraftBukkit Changes:
c2c39089e SPIGOT-2620: Add Player#sendBlockChanges()
8209158db PR-1113: Ignore .checkstyle file generated by Eclipse IDE

Spigot Changes:
4aa5ead2 Rebuild patches
2022-09-24 02:38:12 +01:00
Shane Freeder eb3f66c6da Updated Upstream (Bukkit/CraftBukkit) (#8378) 2022-09-23 06:08:43 +01:00
Shane Freeder ede4468516 Make WorldCreator#keepSpawnLoaded return the WorldCreator (Fixes #8321) (#8371)
* Make WorldCreator#keepSpawnLoaded return the WorldCreator (Fixes #8321)

Thought that I fixed this before push/merge, apparently not, hence, fix
the return type and add mitigation for this.

* Fix patch/build

* Rebuild patches
2022-09-20 01:28:22 +01:00
Shane Freeder e14a2a0cce Configurable chat thread limit (#7878) 2022-09-20 01:16:23 +01:00
Shane Freeder f7b33b60b0 Use thread safe Random inside of ServerLoginPacketListenerImpl
Vanilla uses a Random instance which is not thread safe inside of the
constructor for ServerLoginPacketListenerImpl, this is an issue because
instances of that class are created on the network worker threads, which
means that there is a potential (which we have reports confirming) that
multiple users logging on could trip this
2022-08-11 14:38:45 +01:00
Shane Freeder 53885ac491 Don't manually send ClientboundPlayerPositionPacket for refreshPlayer
in 1.19, mojang made it so that teleporations validate that an awaiting pos was
set in the server when teleporting, thus we need to ensure that this is set when
sending the player pos, otherwise the player will be kicked when the client sends
back the aknowledgement
2022-08-10 15:01:39 +01:00
Shane Freeder f9f8a78753 Fix plugin update IO logic when replacing jars 2022-07-23 05:52:57 +01:00
Shane Freeder 226468f7b0 Cache Component MOTDs 2022-07-23 02:56:50 +01:00
Shane Freeder 93f19c4e41 Add a bit of extra debugging to chat order/time errors
I do wanna add some leeway to the kick, if message was sent within 30-60
seconds of the last message, assume clock drift and just ignore the kick
(send a message? just silently ignore?), but, I'm not 100% on this one
2022-07-06 05:53:16 +01:00
Shane Freeder a029f5d67c Parse MOTD as legacy sectioned string (Fixes #8036)
This is not ideal but this is how MOTDs have been parsed for years,
ensure that this is performed for all things getting the MOTD from
the server
2022-06-22 09:15:20 +01:00
Shane Freeder 348b3a541d Fix missing null check in ChunkGenerator#findNearestMapStructure 2022-06-20 15:01:29 +01:00
Shane Freeder efcee6889d [ci skip] restore jd.io 2022-06-17 18:28:38 +01:00
Shane Freeder bf6042c329 Temp: Disable javadoc.io for now 2022-06-17 08:26:11 +01:00
Shane Freeder 5e5e561112 Bump netty 2022-06-12 23:53:18 +01:00
Shane Freeder 1ef1281f21 Ensure that Log4J is shutdown when stopping the server (Fixes #7932) 2022-06-12 01:59:24 +01:00
Shane Freeder 945316dc5d Add support for Velocity forwarding v2
This is strictly not needed, however, I wanted to write this in part
to test the new forwarding logic, parsing and advertising the latest
featureset is also not exactly a bad thing
2022-06-09 14:27:06 +01:00
Shane Freeder c0a157eb9f Fix don't lookup profiles for blank names patch 2022-06-09 22:37:26 +01:00
Shane Freeder b63b1a42cf Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
9d46b56e2 SPIGOT-7009: Stuck on "Loading terrain..." after disconnecting on respawn screen
2022-06-03 04:31:18 +01:00
Shane Freeder 655a3cf961 Updated Upstream (Bukkit/CraftBukkit) (#7776) 2022-04-30 17:27:41 +01:00
Shane Freeder 8d72e2dfb2 cleanup filtered sign text (#7777) 2022-04-30 16:49:57 +01:00
Shane Freeder 5db9697593 WorldCreator#keepSpawnLoaded (#7673) 2022-04-20 10:26:09 +01:00
Shane Freeder 2b927737c9 Ignore invalid jars inside of the updates folder (Fixes #7751)
This really needs a deeper look here, the way updates are handled is
fairly immature, but, this wasn't ever intended to be a large scale thing

Ideally, imho, we'd collect the list of update files into some form of Map,
that way we just have a reference of Name > File refs, and can filter out
cases where there are two versions of a plugin in there and warn expectidely,
but, that creates some complications, you would need to fall back to a dir
scan in the case of a plugin calling loadPlugin, but, it would at least
give us more defined behavior, as well as improve performance here vs
repeatidely trying to deserialise the plugin.yml defs for every file
in there on every load
2022-04-20 10:00:50 +01:00
Shane Freeder a072a15667 [CI-SKIP] Remove unused import from last patch 2022-04-13 09:15:28 +01:00
Shane Freeder d8d6fd17fd Prevent tile entity copies loading chunks 2022-04-13 08:27:16 +01:00
Shane Freeder c80c018a4e Buffer OOB setBlock calls
lets debug mode throw a trace in order to potentially see where
such calls are cascading from easier, but, generally, if you see one setBlock
call, you're gonna see more, and this just potentially causes a flood of logs
which can cause issues for slower terminals, etc.

We can limit the flood by just allowing one for a single gen region,
we'll also only gen a trace for the first one, I see no real pressing need
to generate more, given that that would *massively* negate this patch otherwise
2022-03-19 12:22:31 +00:00
Shane Freeder a9bcb9deed Add printPaperVersion task 2022-03-04 09:41:03 +00:00
Shane Freeder 1f42cc66e7 Revert chunk postprocessing back to 1.18.1 logic 2022-03-02 18:08:10 +00:00
Shane Freeder d694a49769 Drop unneeded desync patch
spigot no longer even fires the event for this case, so, this may
actually be a regression, not too sure here, but, as-is this patch
is dead
2022-03-02 09:44:22 +00:00
Shane Freeder 0fb6f13944 ignore excessive vel for Minecarts (Fixes #7515) 2022-02-28 15:31:41 +00:00
Shane Freeder d77d3acbc5 Mark ChatRender#render as ApiStatus.Override 2022-02-18 01:10:46 +00:00
Shane Freeder 729db1bed4 Rebuild patches
Cos, you know, pushing the correct changes the first time woulda been
overrated
2022-02-01 13:06:41 +00:00
Shane Freeder f3497a0c5c Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
5c21a63f PR-717: Add PlayerHideEntityEvent and PlayerShowEntityEvent

CraftBukkit Changes:
c26a7b54d PR-1000: Add PlayerHideEntityEvent and PlayerShowEntityEvent
2022-02-01 11:35:36 +00:00
Shane Freeder 295a45f95d Use a CHM for StructureTemplate.Pallete cache
fixes a CME due to this collection being shared across threads

This patch was in 1.16.5 for a good while and noticed somebody
getting impacted by the same thing
2022-02-01 09:47:46 +00:00
Shane Freeder 68ee3947db Fix defaults for slime-spawn-height in paper config
do note that if you happened to grab the previous build in the few minutes it
was alive, you'll want to reset your settings here

also, i
2022-01-11 02:55:05 +00:00
Shane Freeder ffa0464d81 Provide option to disable username validation (Closes #7250) (#7254) 2022-01-02 12:51:22 +00:00
Shane Freeder 52fbecf5f4 Add debug stack for removed player teleporation check 2021-12-29 15:05:23 +00:00
Shane Freeder c78111ca2c Fix migration logic for old player saving config option
This is an ode to all those times when you shoulda just gone to bed
2021-12-28 08:10:38 +00:00
Shane Freeder e185936159 Revert "#686: Fix contains for default section generating real sections"
This commit causes an NPE when getting from the config in some states,
given upstream issue and PR in the works, I have 0 inclination to debug
this

This reverts commit e4358b8217126bbcc3a38b0d17097ad5ab87c50a.
2021-12-05 15:20:52 +00:00
Shane Freeder 61ef48e0ce Revert "fix NPE from changes in e4358b82171"
This reverts commit aa3d405b36.
2021-12-05 15:10:39 +00:00
Shane Freeder 55c371884e Fix trader merchants NPE when interacting with a merchant with non-active trades 2021-12-05 03:00:10 +00:00
Shane Freeder bc04c3f9bc Prevent ContainerOpenersCounter openCount from going negative (Fixes #6865) 2021-12-04 02:50:35 +00:00
Shane Freeder e119488df5 Do not use ForkJoinPool common exector for creating client command struct (Fixes #6936) 2021-12-04 02:37:33 +00:00
Shane Freeder df36d229fc Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
9115281f SPIGOT-6832: Improve Player#getPing docs

CraftBukkit Changes:
fd3478bc7 #967: Store last lava contact location for events

Spigot Changes:
dbf49382 Rebuild patches
58cb9d26 #113: Use simulationDistance for entity activation range base
2021-12-03 21:28:15 +00:00
Shane Freeder bd8e01c675 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
03b725233 SPIGOT-6823: Fix loading custom world in combination with superflat
359d0533a #970: Correct typo in README.md
110492932 Fix per-world worldborder command
2021-12-03 00:26:54 +00:00
Shane Freeder 16ba421c40 Update paperclip to v3.0.2 2021-12-01 09:28:22 +00:00
Shane Freeder edc8a389fc Update jline and TCA (#6829)
Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>

updates jline to 3.21.0, and TCA to 1.3.0
2021-11-02 18:02:16 +00:00
Shane Freeder 4fe89b58d2 Upgrade gson to 2.8.8 (Closes #6370) 2021-10-19 15:32:18 +01:00
Shane Freeder 82418e3a71 create random seeds for features using SecureRandom 2021-10-19 15:25:04 +01:00
Shane Freeder 38d5d85fe4 Clean plugin folder logic in extra-jars patch (Fixes #6347) (#6619) 2021-10-15 22:54:22 +01:00
Shane Freeder 26639f1397 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
9590b610 SPIGOT-6749: Library Loader does not correctly isolate dependencies

CraftBukkit Changes:
11c9299f #940: Fixed a NPE during CraftBlockEntityState#update.
960f3109 #937: Fixes related to unplaced BlockStates and the recent world generation changes.
4faf479e SPIGOT-6754: We ignore any still present TileEntity now when we create a BlockState for a block of type AIR.
a72d5404 SPIGOT-6754: Temporarily restore previous behaviour for tile entities with removed blocks

Spigot Changes:
dc75aca8 Remove redundant 'Log null TileEntity Owner' patch
2021-10-15 12:43:19 +01:00
Shane Freeder 3f3377a1eb Revert "Legacy data should look for legacy materials (Fixes #6618)" (Fixes #6664)
This reverts commit 3ce522545b.
2021-09-29 03:12:40 +01:00
Shane Freeder 3ce522545b Legacy data should look for legacy materials (Fixes #6618) 2021-09-17 09:35:02 +01:00
Shane Freeder 92c68e2367 Fixup enderpearl patch 2021-09-07 22:33:28 +01:00
Shane Freeder eca2f8fdd0 Fix CocaoDecorator causing a crash during generation (Fixes #6028) 2021-09-07 21:41:54 +01:00
Shane Freeder 20e45f7315 Do not process entity loads in CraftChunk#getEntities (Fixes #6543)
This re-introduces the issue behind #5872 but fixes #6543
The logic here is generally flawed however somewhat of a nuance,
upstream uses managedBlock which is basically needed to process
the posted entity adds, but, has the side-effect of processing any
chunk loads which has the naunce of stacking up and either causing a
massive performance hit, or can potentially lead the server to crash.

This issue is particularly noticable on paper due to the cumulative efforts
to drastically improve chunk loading speeds which means that there is much more
of a chance that we're about to eat a dirtload of chunk load callbacks, thus
making this issue much more of an issue
2021-09-03 15:55:22 +01:00
Shane Freeder 2846c01086 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
6719d1f1 SPIGOT-6708: Fix Experience Orb value not being updated in mend event
2021-09-03 15:43:11 +01:00
Shane Freeder 972fbb74c9 Do not fire PlayerBucketFillEvent when no fluid (Fixes #4611) 2021-08-17 15:43:01 +01:00
Shane Freeder 746d5cb8fb Revert "Revert "Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)""
This reverts commit d2f7432e32.
2021-08-14 15:24:53 +01:00
Shane Freeder d2f7432e32 Revert "Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)"
This reverts commit 701cceb170.
2021-08-14 15:22:21 +01:00
Shane Freeder 701cceb170 Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)
Mojang made some changes to priorities in 1.17 and it seems that these changes
conflict with the changes made in this patch, which in some cases appears to
cause excessive rescheduling of tasks.

This, however, is not confirmed as such but seems to be the behavior that we're
seeing to cause this issue, if mojang has adopted the changes we suggested,
then a good chunk of this patch may be unneeded, but, this needs a much better
look than I'm currently able to do
2021-08-14 14:55:55 +01:00
Shane Freeder 0850e18436 Expose EntityType#getTranslationKey 2021-08-11 06:12:57 +00:00
Shane Freeder c45970a2c1 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
75a0ee4f SPIGOT-6691: Material.LAVA_CAULDRON is not Levelled

CraftBukkit Changes:
e1c96e50 SPIGOT-6682: Blocking with shield not reset after die
97f629b6 SPIGOT-6220: Structures in the world with custom generator not work
85379258 Increase outdated build delay
f7f8dce4 SPIGOT-6552: Some inventory types reset cursor on switch
2021-08-04 16:26:56 +01:00
Shane Freeder 06a831d477 Fix SysoutCatcher when plugins log before initialisation (Fixes #6323) 2021-08-04 04:04:12 +01:00
Shane Freeder b3f290d877 Fix some inconsistency issues with empty map items (#6304) 2021-08-01 16:55:25 +01:00
Shane Freeder 3a17437d6f Mark sensor and behavior timings as verbose 2021-08-01 10:22:55 +01:00
Shane Freeder 38e838b0c9 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
aa69d1cf Only remove tile entity if block type changes
2021-07-24 04:44:04 +01:00
Shane Freeder 87ad9b0502 Fix missing annotation 2021-07-13 19:15:18 +01:00
Shane Freeder 4ca03426b0 Expand resource pack API 2021-07-12 20:42:17 +01:00
Shane Freeder 2143a948be Fix NPE when completing skull lookups without a real owner (Fixes #6052)
This looks like mojang introduced an NPE however it was previously being
supressed by the future used by the server, we'll just stick to the legacy
behavior of retainining the existing profile of earlier versions
2021-07-01 00:10:28 +01:00
Shane Freeder aa1d49efd6 [ci skip] revert dev-imports derp 2021-06-30 22:29:54 +01:00
Shane Freeder 0641643c4a Backport MC-229191 ore distribution changes 2021-06-30 22:11:40 +01:00
Shane Freeder 5a5d27f6a1 Fix NPE when using broadcast as players are joining 2021-06-29 22:21:42 +01:00
Shane Freeder 0e2c1c7288 [ci skip] patch-ception 2021-06-29 17:39:17 +01:00
Shane Freeder 73d13c8c88 Don't complete skull lookups on main thread (MC-227435) 2021-06-29 17:34:20 +01:00
Shane Freeder c203932d0c Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
214b9f14 SPIGOT-6605: Add method to access value of enforce-whitelist

CraftBukkit Changes:
b121d3b9 SPIGOT-6605: Add method to access value of enforce-whitelist
2021-06-29 01:31:35 +01:00
Shane Freeder f3e872c626 Fix players not being added to collide rule (Fixes #6024) 2021-06-28 22:16:46 +01:00
Shane Freeder 65c6d7f38f Drop codec spam fix (Fixes #5936)
having spoken to mojang about this the general issue is data which shouldn't
have been saved in the first place, so if we lose this data it's not really
an issue, bar being annoying spammy. if the spam gets on your nerves, shamefully,
all you can really do is forceUpgrade to get the conversions of the way.

Dropping as this breaks other aspects of the server and bar being spammy
seems to have no other real negative outcomes
2021-06-26 12:56:06 +01:00
Shane Freeder 65a6e249ea Allow explosions under 0 height (Fixes #5974)
Upstream forgot to update the check here which prevents explosions
occuring under 0 height, however, vanilla already checks that we
are in bounds of the world above this, so this call is entirely
redundant.
2021-06-24 01:44:23 +01:00
Shane Freeder b3cf50a134 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
f81f4994 SPIGOT-6594: NPE at Bukkit.getServer().getGenerateStructures()
295ab080 #872: SculkSensor accesses underlying TileEntity instead of snapshot for vibration frequency.
2021-06-24 01:39:30 +01:00
Shane Freeder 5b8a29a0cc Ensure disconnect for book edit is called on main 2021-06-22 20:00:11 +01:00
Shane Freeder 4ad15af215 Fix kick event being fired off main thread 2021-06-22 19:35:35 +01:00
Shane Freeder 1599ffc11d Try even harder to get an origin world and avoid NPEs (Fixes #5931) 2021-06-22 11:54:49 +01:00
Shane Freeder 58c3edcb08 Try to prevent an NPE from origin data (Fixes #5905) 2021-06-21 10:04:18 +01:00
Shane Freeder 1763250105 Fix early load perms patch (Fixes #5917) 2021-06-21 09:41:00 +01:00
Shane Freeder e6193a1630 Add invalid player data to misc debug dumps 2021-06-20 15:06:37 +01:00
Shane Freeder e1116fe452 Modify entity origin API to store world/pos seperatly 2021-06-16 06:36:02 +01:00
Shane Freeder d963592869 Do not tick Chunk TickS for every chunk 2021-06-03 06:13:18 +01:00
Shane Freeder 2614cde313 [CI-SKIP] Fixup patch header 2021-06-02 05:51:15 +01:00
Shane Freeder 11743149cd Restore vanilla water animal limit
Spotted by pheonix616, merged into a similar patch for the sake of
the patch numbers :o
2021-06-02 05:45:12 +01:00
Shane Freeder 51b2370434 Do not print spawn loaded chunks
This counter is no longer accurate due to the fact that paper does not block for these loads
to finish
2021-05-30 03:02:23 +01:00
Shane Freeder a0838b17c2 Revert "Remove itneract event from boat" (Fixes #5677) 2021-05-19 13:38:40 +01:00
Shane Freeder b5488de2ba Revert "Updated Upstream (Bukkit/CraftBukkit/Spigot) (#5636)"
This reverts commit 11c2ef5d2f.
2021-05-15 22:10:57 +01:00
Shane Freeder 084ee854f8 Fix missing CraftMetaBook#toBuilder override 2021-05-06 17:27:19 +01:00
Shane Freeder b9ab5132c3 fix isProxyOnlineMode coverage, don't lookup UUIDs in offline mode (Fixes #2011) 2021-05-05 03:54:42 +01:00
Shane Freeder eccfbfe377 Send empty commands if tab completion is disabled (Closes #5519)
Because this is a trivial fix to an annoying issue people are annoying
about, but, really, stop punishing your players for your own insecurities.
2021-05-05 03:22:32 +01:00
Shane Freeder 2b12d671fa don't throw when loading TE with invalid keys 2021-04-21 20:05:50 +01:00
Shane Freeder 3e0a36dbbd Fix dangling sout 2021-04-18 22:12:09 +01:00
Shane Freeder 3007bdc020 basic hostname validation 2021-04-18 21:47:01 +01:00
Shane Freeder dcdfac1f8c remove l4j class no longer in existence from preload list 2021-04-12 05:16:16 +01:00
Shane Freeder 68f0738631 Properly apply Sign#isEditable to TEs when calling BlockState#update 2021-03-23 06:46:54 +00:00