Commit Graph
100 Commits
Author SHA1 Message Date
Jake Potrebic aa5add485f work on adventure 2024-04-24 20:14:51 -07:00
Jake Potrebic 21581c8111 955 2024-04-24 16:25:57 -07:00
Jake Potrebic 27c46717f6 405 2024-04-23 23:44:48 -07:00
Jake Potrebic 49787270cb 354 2024-04-23 23:05:14 -07:00
Jake Potrebic ebedfa4da7 301 2024-04-23 22:43:09 -07:00
Jake Potrebic 840f63b25a 253 2024-04-23 19:46:06 -07:00
Jake Potrebic e45f4f85f4 221 2024-04-23 19:21:40 -07:00
Jake Potrebic 9a497c83b8 fix 2 of our javadoc errors 2024-04-23 16:30:24 -07:00
Jake Potrebic 8c0153f78d work on some API stuff 2024-04-23 16:26:24 -07:00
Jake Potrebic 5c6e2be729 work on Adventure patch 2024-04-23 11:32:19 -07:00
Jake Potrebic 7f1e33effe do some work 2024-04-23 11:03:16 -07:00
Jake Potrebic 47ee5579ff Begin update to 1.20.5 2024-04-23 10:02:08 -07:00
Jake Potrebic 659ebace6c More Raid API (#7537) 2024-04-20 12:57:51 -07:00
Jake Potrebic bdfe4c21f6 Add API for ticking fluids (#10435)
* Add API for ticking fluids

* update javadocs
2024-04-19 13:03:32 -07:00
Jake PotrebicandJason Penilla 89528bff42 Update patches to handle vineflower decompiler (#10406)
* Update patches to handle vineflower decompiler

* update patches again to handle inlined simple lambdas

* update vf again and re-apply/rebuild patches

* update patches after removal of verify-merges flag

* fix compile issue

* remove maven local

* fix some issues

* address more issues

* fix collision patch

* use paperweight release

* more fixes

* update fineflower and fix patches again

* add missing comment descriptor

---------

Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
2024-04-12 12:14:06 -07:00
Jake Potrebic 7263a87e9c Deprecate several Keyed#getKey methods (#10357)
- Structure (can already be defined inline in datapacks
- PatternType (can be defined inline in 1.20.5 data components)
- MusicInstrument (same as above)
2024-04-07 22:20:51 -07:00
Jake Potrebic 68e86d7297 Updated Upstream (Bukkit/CraftBukkit) (#10379)
Updated Upstream (Bukkit/CraftBukkit)

Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
f02baa38 PR-988: Add World#getIntersectingChunks(BoundingBox)
9321d665 Move getItemInUse up to LivingEntity
819eef73 PR-959: Add access to current item's remaining ticks
c4fdadb0 SPIGOT-7601: Add AbstractArrow#getItem
be8261ca Add support for Java 22
26119676 PR-979: Add more translation keys
66753362 PR-985: Correct book maximum pages and characters per page documentation
c8be92fa PR-980: Improve getArmorContents() documentation
f1120ee2 PR-983: Expose riptide velocity to PlayerRiptideEvent

CraftBukkit Changes:
dfaa89bbe PR-1369: Add World#getIntersectingChunks(BoundingBox)
51bbab2b9 Move getItemInUse up to LivingEntity
668e09602 PR-1331: Add access to current item's remaining ticks
a639406d1 SPIGOT-7601: Add AbstractArrow#getItem
0398930fc SPIGOT-7602: Allow opening in-world horse and related inventories
ffd15611c SPIGOT-7608: Allow empty lists to morph to any PDT list
2188dcfa9 Add support for Java 22
45d6a609f SPIGOT-7604: Revert "SPIGOT-7365: DamageCause blocked by shield should trigger invulnerableTime"
06d915943 SPIGOT-7365: DamageCause blocked by shield should trigger invulnerableTime
ca3bc3707 PR-1361: Add more translation keys
366c3ca80 SPIGOT-7600: EntityChangeBlockEvent is not fired for frog eggs
06d0f9ba8 SPIGOT-7593: Fix sapling growth physics / client-side updates
45c2608e4 PR-1366: Expose riptide velocity to PlayerRiptideEvent
29b6bb79b SPIGOT-7587: Remove fixes for now-resolved MC-142590 and MC-109346
2024-04-06 12:53:39 -07:00
Jake Potrebic 8fa3b24907 [ci skip] move custom brig exception to paper package 2024-03-26 08:38:26 -07:00
Jake Potrebic 3e27ced8ce Clone mutable types in events when changes are discarded (#10333) 2024-03-20 13:42:29 -07:00
Jake Potrebic c47e305c9f Fix DamageSource API (#10307)
Uses the correct entity in the EntityDamageByEntity event
Returns the correct entity for API's DamageSource#getCausingEntity
2024-03-16 11:51:22 -07:00
Jake Potrebic 31997fcd56 Add param to overrides to the correct method is called (#10308) 2024-03-09 15:16:27 -08:00
Jake Potrebic 8b00b9a52d Updated Upstream (Bukkit/CraftBukkit) (#10301)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
7ca2b46c SPIGOT-7594: Fix typo and include missing MinecraftExperimental annotation in Loot Table enum

CraftBukkit Changes:
176c0ad39 Fix copying BlockStates with fields (eg, Banner)
ee685bd2a Fix Camel not standing up when hurt
619936d4b Increase outdated build delay
2024-03-08 15:52:00 -08:00
Jake Potrebic ee3ba92337 Per world ticks per spawn settings (#6891) 2024-03-03 14:53:58 -08:00
Jake Potrebic a2a55e2b27 Deprecate extra ban methods with raw BanEntry (#9580) 2024-03-03 12:54:52 -08:00
Jake Potrebic 1f16b25f9e Fire entity knockback event for ownerless tnt (#7171) 2024-02-16 15:44:43 -08:00
Jake Potrebic e8e83aefff Properly track the changed item from dispense events (#8658) 2024-02-10 13:17:24 -08:00
Jake Potrebic d767c37a54 Fix possible StackOverflowError for some dispenser iteractions (#8524) 2024-02-10 12:17:40 -08:00
Jake Potrebic 4f9f09bb9b Lifecycle Event System (#9629)
* registering stuff event system

* simply by removing a ton of unneeded generics

* separate RegistryEvent and RegistrarEvent

* add logic for removing hooks when a plugin is disabled

* cleanup more

* swap around the way things are registered

* block further hook registrations for JavaPlugin

* Slightly more extensible to support registry mod API

* rename some types

* more moving/renaming

* remove 'hook' name

* Rename to 'lifecycle'

* move more impls for the server

* add priorities

* added lock for bootstrap event registration

* slight refactor to allow 'register anywhere' event types

* Move event type list to server impl

* use builder pattern to create event handler configurations

* add some more javadocs

* fix some issues, slight refactors

* call predicate and method renames

* add owner aware events

* rebased and refactored owner aware events

* add single helper method for registering simple handler

* compile fixes

* check owner and fix generics on register helper

* javadoc fixes and a few type renames

* more javadoc fixes

* move service loader file to correct location

* rename to Monitorable and Prioritizable

* add invalidation system for events after running them

* block reloading plugins in certain situations

* update test plugin

* remove dummy events

* rebase
2024-02-09 12:12:01 -08:00
Jake Potrebic cc0082f248 Properly check if a loot table exists (#10190) 2024-01-27 11:21:18 -08:00
Jake Potrebic a86380bc18 [ci skip] clarify javadocs for Block#getDrops (#10153) 2024-01-27 09:35:09 -08:00
Jake Potrebic b9b956adb8 Add BlockStateMeta#clearBlockState (#10160) 2024-01-23 12:41:47 -08:00
Jake Potrebic fa7d1b668f Updated Upstream (Bukkit/CraftBukkit/Spigot) (#10164)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
63c208dd Remove no longer used import
70be76c7 PR-958: Further clarify deprecation of TAG_CONTAINER_ARRAY
ae21f4ac PR-955: Add methods to place structures with block/entity transformers
e3d960f2 SPIGOT-7547: Remark that Damageable#setAbsorptionAmount() is capped to a specific value
b125516c Fix typo in RecipeChoice.ExactChoice docs
309497c1 Add EntityMountEvent and EntityDismount Event
2fd45ae3 Improve ItemFactory#enchantItem consistency
2b198268 PR-933: Define native persistent data types for lists

CraftBukkit Changes:
771182f70 PR-1327: Add methods to place structures with block/entity transformers
e41ad4c82 SPIGOT-7567: SpawnReason for SNOWMAN is reported as BUILD_IRONGOLEM
76931e8bd Add EntityMountEvent and EntityDismount Event
9b29b21c7 PR-1183: Better handle lambda expression and renaming of classes in Commodore
1462ebe85 Reformat Commodore.java
9fde4c037 PR-1324: Improve ItemFactory#enchantItem consistency
4e419c774 PR-1295: Define native persistent data types for lists
dd8cca388 SPIGOT-7562: Fix Score#getScore and Score#isScoreSet
690278200 Only fetch an online UUID in online mode
1da8d9a53 Fire PreLogin events even in offline mode
2e88514ad PR-1325: Use CraftBlockType and CraftItemType instead of CraftMagicNumbers to convert between minecraft and bukkit block / item representation

Spigot Changes:
864e4acc Restore accidentally removed package-info.java
f91a10d5 Remove obsolete EntityMountEvent and EntityDismountEvent
828f0593 SPIGOT-7558: Deprecate silenceable lightning API as sound is now client-side and cannot be removed
cdc4e035 Remove obsolete patch fetching correct mode UUIDs
49e36b8e Merge related BungeeCord patches
6e87b9ab Remove obsolete firing of PreLogin events in offline mode
5c76b183 Remove redundant patch dealing with exceptions in the crash reporter
3a2219d1 Remove redundant patch logging cause of unexpected exception
2024-01-14 01:46:04 -08:00
Jake Potrebic a5eaf39caf [ci skip] add more comments & move 1 hunk to correct patch 2024-01-13 12:31:02 -08:00
Jake Potrebic fcd5a14216 Use a ConcurrentHashMap for enum mappings for BlockData (#10161)
This API should be thread-safe as there is no world state
2024-01-12 08:25:12 -08:00
Jake Potrebic acaa9f2d3f Log command execution exceptions if debug=true (#10130) 2024-01-11 08:15:17 -08:00
Jake Potrebic 0797dd4643 Fix a borked update of 'Properly handle BlockBreakEvent#isDropItems' (#10134) 2024-01-05 01:07:43 -08:00
Jake Potrebic 4820459600 Fix EntityChangePoseEvent being called during worldgen (#10120) 2024-01-04 12:55:01 -08:00
Jake Potrebic 9bfe2bcce9 Fix cmd permission levels for command blocks (#7404) 2024-01-04 12:37:59 -08:00
Jake Potrebic 6c5ad653e5 Fix untrack event not being called for all 'untracks' (#10110) 2024-01-03 20:57:49 -08:00
Jake Potrebic 9f932e42bd include relative flags in PlayerTeleportEvent (#8190) 2024-01-02 11:42:26 -08:00
Jake Potrebic 324d220679 fix CustomModelData being removed (#10113) 2024-01-02 10:51:09 -08:00
Jake Potrebic 8f3f70d786 Call EntityChangeBlockEvent for cake eating (#10105) 2024-01-02 10:45:36 -08:00
Jake Potrebic 60beb05297 [ci skip] Remove extraneous diff added in 1.20.3 update (#10101) 2024-01-02 10:29:53 -08:00
Jake Potrebic e9e8abc91d Correctly check if bucket dispenses will succeed for event (#10109) 2024-01-02 09:14:42 -08:00
Jake Potrebic ee6a9c50d8 cleanup player death event adventure logic (#10095)
There was a TODO left there regarding the translated death
message being used by plugins to identify the cause of death. This
should be mitigated now because the LegacyComponentSerializer default
implemenation uses our custom flattener which renders vanilla
translatable components to their English representation.
2023-12-29 12:28:58 -08:00
Jake Potrebic e1faa8e814 Call entity_die game event after event cancel check (#10096) 2023-12-29 11:57:32 -08:00
Jake Potrebic 0c4e87fd28 Properly disallow async Player#chat (#8123)
Clarify asynchronous status of AsyncChatEvent
2023-12-28 16:50:06 -08:00
Jake Potrebic e7beaa38ba Add drops to shear events (#5678) 2023-12-28 14:41:07 -08:00
Jake Potrebic cca94c1a21 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#10085)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
0c7aedbc SPIGOT-7554, PR-954: Add DecoratedPotInventory

CraftBukkit Changes:
53ebb05e3 SPIGOT-7554, PR-1323: Add DecoratedPotInventory
33a2d8773 Ensure that PlayerMoveEvent is always fired where applicable
7df18510f SPIGOT-7555: Don't cast ItemFlags to byte
19aec59ea Use provided case for non-existent OfflinePlayers

Spigot Changes:
e7ce55a3 Remove obsolete PlayerMoveEvent improvements
3e5e22c0 Remove obsolete lowercasing of non existent OfflinePlayer names
2023-12-28 12:47:57 -08:00
Jake Potrebic 4d050226c3 Fix global sound event gamerule not being respected (#8727) 2023-12-27 16:33:05 -08:00
Jake Potrebic 5e518056e2 Fix campfire recipes not always outputting full result (#8754) 2023-12-27 15:02:49 -08:00
Jake Potrebic addfcd57a1 Don't fire 2 game events for certain cauldron interactions (#8904) 2023-12-27 14:32:39 -08:00
Jake Potrebic 2461bcfe65 Fix command block async message (again) (#10082) 2023-12-27 01:30:15 -08:00
Jake Potrebic 7ecbd18f48 fix NPE on EntityTeleportEvent getTo (#10016) 2023-12-26 11:22:41 -08:00
Jake Potrebic 3786f007a3 [ci skip] cleanup patch diff from last commit 2023-12-25 16:47:06 -08:00
Jake Potrebic cdcf832673 Update to adventure 4.15 (#10045) 2023-12-25 02:51:44 -08:00
Jake Potrebic 50364f320c Add Registry#getKey (#10066)
Some types that have registries support existing without
being in a registry and therefore have no key. This is part
one of supporting that, adding a Registry#getKey(Object) method
to be able to get the key for an object so we can remove Keyed
from such objects.

This also deprecates Keyed#getKey on TrimMaterial and TrimPattern
as these are the 2 offending types currently in the api.
2023-12-23 13:16:27 -08:00
Jake Potrebic 0c9b5e23ab Fix and add new scoreboard API (#10037) 2023-12-23 11:53:07 -08:00
Jake Potrebic e93ec8f95d Remove 'fix Vanilla Minecart speed' patch (#10068)
The game uses 0.95d now
2023-12-22 17:44:36 -08:00
Jake Potrebic 0ff8861f60 add missing Experimental annotations (#10012) 2023-12-21 13:13:05 -08:00
Jake Potrebic 5ba15732d7 Remove duplicate code in chunk tick iteration (#10056) 2023-12-21 09:15:00 -08:00
Jake Potrebic 9ac075e78e Use correct max stack size in crafter (#10057) 2023-12-21 09:10:28 -08:00
Jake Potrebic 0f74988507 properly read and store sus effect duration (#10050) 2023-12-19 13:31:49 -08:00
Jake Potrebic 516942a4d5 Don't fire the drop event on player deaths (#10046) 2023-12-18 20:57:49 -08:00
Jake Potrebic b66d200b4b hotfix spawning item/xp in wrong spot 2023-12-17 20:23:39 -08:00
Jake Potrebic 5497c308d9 send sound and particle packets immediately even if off main (#10033) 2023-12-17 11:39:40 -08:00
Jake Potrebic 6f7ee18a4c Updated Upstream (Bukkit/CraftBukkit) (#10034)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
f29cb801 Separate checkstyle-suppressions file is not required
86f99bbe SPIGOT-7540, PR-946: Add ServerTickManager API
d4119585 SPIGOT-6903, PR-945: Add BlockData#getMapColor
b7a2ed41 SPIGOT-7530, PR-947: Add Player#removeResourcePack
9dd56255 SPIGOT-7527, PR-944: Add WindCharge#explode()
994a6163 Attempt upgrade of resolver libraries

CraftBukkit Changes:
b3b43a6ad Add Checkstyle check for unused imports
13fb3358e SPIGOT-7544: Scoreboard#getEntries() doesn't get entries but class names
3dda99c06 SPIGOT-7540, PR-1312: Add ServerTickManager API
2ab4508c0 SPIGOT-6903, PR-1311: Add BlockData#getMapColor
1dbdbbed4 PR-1238: Remove unnecessary sign ticking
659728d2a MC-264285, SPIGOT-7439, PR-1237: Fix unbreakable flint and steel is completely consumed while igniting creeper
e37e29ce0 Increase outdated build delay
c00438b39 SPIGOT-7530, PR-1313: Add Player#removeResourcePack
492dd80ce SPIGOT-7527, PR-1310: Add WindCharge#explode()
e11fbb9d7 Upgrade MySQL driver
9f3a0bd2a Attempt upgrade of resolver libraries
60d16d7ca PR-1306: Centralize Bukkit and Minecraft entity conversion

Spigot Changes:
06d602e7 Rebuild patches
2023-12-16 18:09:28 -08:00
Jake PotrebicandJason Penilla 6e3d7add28 Use Codecs for adventure Component conversions & network serialization (#10014)
* finish implementing all adventure components in codecs

* add some initial tests

* Add round trip tests for text and translatable components

* Add more round trip test data (score component is failing)

* Add more round trip test data

* Fix SCORE_COMPONENT_MAP_CODEC

* Improve test failure messages

* Add failure cases

* Add a couple more test data

* Make use of AdventureCodecs

* Update patches after rebase

* Squash changes into adventure patch

* Fix AT formatting

* update comment

---------

Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
2023-12-11 22:02:06 -08:00
Jake Potrebic a3a40ecd2b fix NPE when iterating over default drops (#10017) 2023-12-10 10:33:36 -08:00
Jake Potrebic 5954b852d8 Update key gen for 1.20.4 (#10015) 2023-12-10 10:25:01 -08:00
Jake Potrebic 4d968b5fe5 Update and clean up api dependencies (#10018) 2023-12-10 10:04:19 -08:00
Jake Potrebic b86d22ac6c more work on adventure codecs 2023-12-08 21:48:02 -08:00
Jake Potrebic 5db582ae19 remove redundant patch 2023-12-08 15:14:42 -08:00
Jake Potrebic 93dcf918f8 more cleanup and resource pack api fixes 2023-12-08 15:13:02 -08:00
Jake Potrebic b21ac86cac fixup tests and add missing API detected by those tests 2023-12-08 12:07:56 -08:00
Jake Potrebic 40d0f2da71 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
01bb6ba7 PR-936: Add new PersistentDataContainer methods and clean up docs
bc145b90 PR-940: Create registry for banner pattern and cat type

CraftBukkit Changes:
cb2ea54de SPIGOT-7440, PR-1292: Fire EntityTeleportEvent for end gateways
4fea66e44 PR-1299: Add new PersistentDataContainer methods and clean up docs
b483a20db PR-1303: Create registry for banner pattern and cat type
4642dd526 SPIGOT-7535: Fix maps not having an ID and also call MapInitializeEvent in more places
2023-12-08 11:00:39 -08:00
Jake Potrebic a47c19cb77 more adventure codec stuff
and fix tests
2023-12-07 11:14:29 -08:00
Jake Potrebic fc6af9c088 cleanup Optimize MappedRegistry patch 2023-12-06 22:41:13 -08:00
Jake Potrebic 916f988912 more compile fixes 2023-12-06 10:36:49 -08:00
Jake Potrebic 286f49b866 fix more compile issues 2023-12-06 10:07:47 -08:00
Jake Potrebic b7a964f387 Upstream blocked Player#remove so our patch needed to be refactored 2023-12-06 09:54:52 -08:00
Jake Potrebic ba9e6cf5d3 fix mismatched bracket in game packet listener 2023-12-06 09:47:45 -08:00
Jake Potrebic 8e871314ef fix serializing TextColor with name 2023-12-05 20:56:02 -08:00
Jake Potrebic ec61d23300 initial work on native Adventure codecs 2023-12-05 16:49:11 -08:00
Jake Potrebic a433529d07 port UnknownCommandEvent patch 2023-12-05 13:51:34 -08:00
Jake Potrebic 727bda93be Add Structure check API (#9062) 2023-12-02 18:11:57 -08:00
Jake Potrebic c93b73ddaa Restore vanilla entity drops behavior (#7650) 2023-12-02 17:35:10 -08:00
Jake Potrebic 1d8eb1581e [ci skip] Add mention of FQ imports (#9994) 2023-12-02 13:52:14 -08:00
Jake Potrebic c270039723 Log correct recipes and advancement count on server start (#9978) 2023-12-02 13:17:35 -08:00
Jake Potrebic a60f62506f Un-experimentalize Entity TP APIs (#9964) 2023-11-28 11:40:25 -08:00
Jake Potrebic cea171de11 Use ? super in Consumer/Predicate API (#9939) 2023-11-25 15:03:02 -08:00
Jake Potrebic a3ef5fd4dd Updated Upstream (Bukkit/CraftBukkit/Spigot) (#9953)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
96340858 PR-938: Various Sound API improvements
cbfe0ff0 PR-937: Minor improvements to World#rayTrace documentation
e979ee95 PR-935: Change Consumer and Predicates to super
27ae46dc SPIGOT-3641, SPIGOT-7479, PR-931: Add missing values to EntityEffect
0616ec8b Add eclipse .factorypath file to .gitignore

CraftBukkit Changes:
8e162d008 PR-1301: Various Sound API improvements
eeb7dfc2d SPIGOT-7520: Attribute LootTableSeed missing for generated containers with attached LootTable
d433f086d PR-1297: Change Consumer and Predicates to super
864f616da SPIGOT-7518: Fix NullPointerException when calling Block#applyBoneMeal()
5a2d905af Add eclipse .factorypath file to .gitignore
7c6bf15d4 Fix SkullMeta configuration serialization / deserialization with note block sound

Spigot Changes:
7de1049b Rebuild patches
2023-11-25 14:34:42 -08:00
Jake Potrebic 635d3870ee Don't fire EntityPotionEffectEvent during worldgen (#9965) 2023-11-25 14:18:37 -08:00
Jake Potrebic 867ce6cc0a Code Generation for TypedKeys (#9233)
Currently includes generated key holder classes for types
used in the Registry Modification API
2023-11-22 20:56:28 -08:00
Jake Potrebic 7693140ca0 More paper config cleanup (#9938)
Also adds a warning and error message if a newer config version
was found signaling a downgrade.
2023-11-18 16:29:14 -08:00
Jake PotrebicandOwen1212055 72f5e76f9b Fix spawners checking max nearby entities with correct type (#8945)
Co-authored-by: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>
2023-11-18 15:59:12 -08:00
Jake Potrebic bbd013be54 Run the chat callback on the main thread as expected (#9935) 2023-11-11 15:33:19 -08:00
Jake Potrebic 776cc1199a Fix several issues with EntityBreedEvent (#8677)
Upstream did not account for different hands when storing
the breed item for later use in the event. Also they only
stored a reference to the stack, not a copy so if the stack
changed after love mode was started, the breed item in the event
also changed. Also in several places, the breed item was stored after
it was decreased by one to consume the item.
2023-11-11 15:23:02 -08:00
Jake Potrebic caf899f62b Deprecate Material#isInteractable (#9216) 2023-11-11 14:21:22 -08:00
Jake Potrebic 932b0256c7 Use ApiStatus.Internal instead of Deprecated (#9042)
Mainly correctly marks a lot of still used "magic values"
as Internal instead of "Deprecated".
2023-11-11 13:52:32 -08:00