Minecrell d4ccc60986 Avoid Netty buffer leak in LegacyPingHandler. Fixes #1200 (#1201) ...

The extra buffer used to decode the strings sent by the client
in the legacy ping protocol was never released. However, creating
an extra copy of the buffer just to decode it to a string isn't
actually necessary: We can just call toString() directly on the
original buffer.

Additionally, free the buffer in handlerRemoved() to handle cases
where the client never sends enough bytes to form a valid legacy
ping request.

2018-07-13 09:43:56 +02:00

5.9 KiB

Raw Blame History

View Raw