Commit Graph
100 Commits
Author SHA1 Message Date
Andrew Steinborn 92865b0307 Velocity 1.1.5 2021-04-22 11:23:57 -04:00
Andrew Steinborn ce26ae76c2 Fix case-sensitivity for ping passthrough 2021-04-22 11:23:42 -04:00
Andrew Steinborn ca52f8989e Load forced hosts as lowercase too, see #464 2021-04-18 08:22:36 -04:00
Andrew Steinborn ff54622663 Forced hosts should be case-insensitive. Fixes #464 2021-04-18 08:20:04 -04:00
Andrew Steinborn f1cb3eb1a2 Move timeout handler to after frame decoder
Mitigates attacks like the one described in SpigotMC/BungeeCord#3066. This cannot be considered a full protection, only a mitigation that expects full packets. The attack described is essentially the infamous Slowloris attack.
2021-04-15 22:56:37 -04:00
Andrew Steinborn c51359e893 Move away from deprecated percent() method.
Also fixed another small nit.
2021-04-15 04:23:59 -04:00
Andrew Steinborn 4de71fe942 Fix color and overlay packets for Adventure boss bar
Someone discovered this bug but decided not to tell anyone. For the record, I'm the one who was brain-damaged... well, I made that particular copy-paste error.
2021-04-15 04:22:44 -04:00
Andrew SteinbornandGitHub be21ac5a30 [ci-skip] Update license in README 2021-03-31 20:36:08 -04:00
Andrew SteinbornandGitHub c747120b20 Relicense the Velocity proxy under the terms of GPLv3 (#448) 2021-03-31 16:04:06 -04:00
Andrew Steinborn 514115a85c Do not use an ASCII string for handshake 2021-03-30 12:10:55 -04:00
Andrew Steinborn f88283f127 Revert "Revert strict handshake hostname checks"
This reverts commit 4f80d2b261.

Experience elsewhere (Waterfall PR) and confirmation from TCPShield means
this ought to work. Let's hope.
2021-03-30 12:08:08 -04:00
Andrew Steinborn 8aad6e2ece clear input buffer in case of bad varints 2021-03-30 12:05:43 -04:00
Andrew Steinborn 0cc300b621 don't swap these two around 2021-03-23 07:38:07 -04:00
Andrew Steinborn 3111816545 Warn about null permission functions. 2021-03-23 07:32:01 -04:00
Andrew Steinborn 015693090f Fix typo (thanks zml) 2021-03-21 16:17:41 -04:00
Andrew Steinborn da54a091fb Allow the java.lang module to be opened, as a temporary Java 15+ workaround 2021-03-21 16:16:19 -04:00
Andrew Steinborn 4206457fbc Bump Adventure to 4.6.0 2021-03-02 12:33:47 -05:00
Andrew Steinborn 72d47b5a3d Don't advertise the BungeeCord plugin messaging channel if it is disabled. 2021-02-18 18:12:51 -05:00
Andrew Steinborn 1a768bda9d We're going to need custom hash maps after all. 2021-02-16 01:15:58 -05:00
Andrew Steinborn b94303d2be Map command nodes being serialized by their identities
Fixes #429
2021-02-16 01:14:22 -05:00
Andrew Steinborn 2a8a982538 Velocity 1.1.5-SNAPSHOT 2021-02-13 18:08:50 -05:00
Andrew Steinborn d1229ddca8 Velocity 1.1.4 2021-02-13 18:06:26 -05:00
Andrew Steinborn ae6f2cba2a Bump to Adventure 4.5.0 2021-02-13 18:02:09 -05:00
Andrew SteinbornandGitHub 27ccb9d387 Merge pull request #421 from Bastian/bstats-update
Update bStats and migrate to new config file
2021-02-13 02:04:43 -05:00
Andrew Steinborn 3aee47166f Allow clearing favicon in ServerPing builder. 2021-02-09 14:36:16 -05:00
Andrew SteinbornandGitHub 55cc416b52 Merge pull request #428 from Camotoy/registerevent
Add PlayerRegisterChannelEvent
2021-02-09 14:26:34 -05:00
Andrew Steinborn a6a9d1e0fb Forward slashes are allowed in channel IDs
Fixes an issue where the Fabric registry sync packet would not be allowed by Velocity.
2021-02-09 14:25:12 -05:00
Andrew Steinborn 7e42c5b2e7 Turn some APIs into no-ops if they apply to clients without the relevant client functionality. 2021-02-07 15:19:59 -05:00
Andrew Steinborn b88c573eb1 Correctly forward the player's virtual host to the remote server. 2021-02-01 16:17:02 -05:00
Andrew Steinborn 4f80d2b261 Revert strict handshake hostname checks
These will break TCPShield and Cosmic Guard plugins. Sad as this was a worthwhile mitigation.
2021-01-29 23:08:14 -05:00
Andrew Steinborn 501853e807 Fix Checkstyle issue for the umpteenth time... 2021-01-29 17:59:00 -05:00
Andrew Steinborn 4f6d238b39 Strictly limit the hostname size and limit it to ASCII characters only 2021-01-29 17:56:50 -05:00
Andrew Steinborn 4219bf7b09 *Actually* fix Checkstyle issues 2021-01-26 20:02:07 -05:00
Andrew Steinborn b982c5b6ed Fix Checkstyle issues 2021-01-26 19:59:29 -05:00
Andrew SteinbornandGitHub 77656615bb Fix job name 2021-01-26 19:56:17 -05:00
Andrew SteinbornandGitHub db959b6051 Add GitHub Actions to replace Travis 2021-01-26 19:55:26 -05:00
Andrew Steinborn 0c90e94e85 fix 2021-01-26 19:50:43 -05:00
Andrew Steinborn 5ceac16a82 Add upfront size checks for some packets.
This is simply a further protection against certain attacks which send malformed packets to the proxy.
2021-01-26 12:33:35 -05:00
Andrew Steinborn 959e75d16d Revert "Also provide a "proper" java.util.logger logger to plugins."
This reverts commit 8d71ea7135.

Totally broken
2021-01-25 09:46:42 -05:00
Andrew Steinborn 8d71ea7135 Also provide a "proper" java.util.logger logger to plugins. 2021-01-25 01:54:50 -05:00
Andrew Steinborn 4bc76b3012 Add JUL support to log4j
Certain badly behaved plugins insist on logging with java.util.logging. Accommodate them.
2021-01-25 01:51:32 -05:00
Andrew SteinbornandGitHub 68ae92f977 Merge pull request #419 from 0-x-2-2/dev/1.1.0
Use keepalive queue instead of just the last keepalive.
2021-01-23 20:18:14 -05:00
Andrew Steinborn 03e9fa79d6 Raise limit on JoinGame NBT reading to 2MiB.
This is required for particularly large mod packs (think All of Fabric 3 for instance).
2021-01-23 12:55:28 -05:00
Andrew Steinborn fcffccf0d8 Fix typo 2021-01-23 01:35:49 -05:00
Andrew Steinborn ce7d1dcb26 A new year, a new color for Velocity! 2021-01-23 01:34:46 -05:00
Andrew SteinbornandGitHub a2a799a8a7 Update CONTRIBUTING.md 2021-01-22 19:50:31 -05:00
Andrew SteinbornandGitHub 13ee59d20b Update CONTRIBUTING.md 2021-01-22 19:49:38 -05:00
Andrew Steinborn 892ac6f626 Accept changes to compression treshold on the fly.
Vanilla allows this for some reason, and there has been one case where Velocity's strict behavior has caused a bug. Fix this.
2021-01-21 17:58:09 -05:00
Andrew Steinborn 0fa61216e7 Bump to Adventure 4.4.0 2021-01-19 02:40:32 -05:00
Andrew Steinborn 919319438d Bump Netty version to 4.1.58.Final 2021-01-17 00:43:35 -05:00
Andrew Steinborn 567a3b2365 Swallow and more usefully log exceptions in scheduler task running. 2021-01-09 16:39:38 -05:00
Andrew Steinborn ba1c1eef64 More clarification 2021-01-06 13:30:57 -05:00
Andrew Steinborn 4df8f70156 Rename proxy-protocol setting to haproxy-protocol to make it clearer this is for HAProxy. 2021-01-06 13:29:30 -05:00
Andrew Steinborn 1f9c24566d Fix off-by-one error in MinecraftCompressEncoder 2020-12-31 13:18:01 -05:00
Andrew Steinborn 42d211bf08 Velocity 1.1.4-SNAPSHOT 2020-12-29 18:07:14 -05:00
Andrew Steinborn 44046fe772 Velocity 1.1.3 2020-12-29 18:06:46 -05:00
Andrew Steinborn dc7ab0f7f5 Log server backpressure 2020-12-27 18:36:54 -05:00
Andrew Steinborn 2a1e83902d Add support for server-side backpressure 2020-12-27 18:05:27 -05:00
Andrew Steinborn 7329d165f6 2021 2020-12-26 21:56:19 -05:00
Andrew Steinborn 6a8ec21f26 Use a different quiet exception type to indicate the user should enable a debugging flag if needed 2020-12-26 20:59:17 -05:00
Andrew Steinborn f6078e9b74 Fix several problems and clean up the BungeeCord plugin messaging support.
Fixes #402
2020-12-26 20:52:12 -05:00
Andrew Steinborn b1f7980c5d Fix ForwardToPlayer subchannel, closes #406 2020-12-26 19:49:28 -05:00
Andrew Steinborn 7fe2fc71e9 Add some small debug for refcount issues with plugin messages. 2020-12-25 17:03:38 -05:00
Andrew Steinborn 07b95d46ac Delay sending stats to bStats for 3-5 minutes after server startup 2020-12-21 20:14:57 -05:00
Andrew Steinborn eb3868d911 Do not try to override colors in messages or server-sent messages 2020-12-21 19:56:17 -05:00
Andrew SteinbornandGitHub ce34a8c1b5 Merge pull request #405 from zml2008/fix/jd-search
build: Fix search when generating Javadoc with broken java versions
2020-12-21 15:19:10 -05:00
Andrew Steinborn 98b74fd220 Correctly retain message buffer for LoginPluginMessage.
Fixes #407
2020-12-21 13:14:38 -05:00
Andrew Steinborn 9c375f337b Bump to Netty 4.1.56.Final 2020-12-17 21:16:46 -05:00
Andrew Steinborn 523b61e0c7 Make sure unit tests actually run(!) and fix command hints 2020-12-14 14:39:39 -05:00
Andrew Steinborn 4f5c315ef8 Remove netty-resolver-dns dependency
Geyser has fixed the issue in the latest builds
2020-12-14 04:29:28 -05:00
Andrew Steinborn 991aaa31b1 Revert "Stop bundling the Netty DNS resolver, we don't use it"
This reverts commit 88a57b77df.

Breaks Geyser
2020-12-13 18:47:47 -05:00
Andrew Steinborn 8c52341ff6 Do not pull in transitive dependencies of adventure-text-serializer-legacy-text3
Fixes #401
2020-12-13 15:33:19 -05:00
Andrew SteinbornandGitHub 3efb84d62f Merge pull request #400 from jkcoxson/dev/1.1.0
Fix grammer and spelling in the default config
2020-12-12 01:50:57 -05:00
Andrew Steinborn 88a57b77df Stop bundling the Netty DNS resolver, we don't use it 2020-12-10 06:56:19 -05:00
Andrew Steinborn aef0e4a825 Update Netty to 4.1.55.Final. 2020-12-09 22:25:06 -05:00
Andrew Steinborn 2a5bb1e487 Fix tab list clearing bug.
Fixes regression introduced in 5da085d
2020-12-07 02:28:03 -05:00
Andrew Steinborn fa2655d49b Fix the debug message 2020-11-24 12:09:49 -05:00
Andrew Steinborn aa7aee9dd7 Add another validation case although it's not strictly required 2020-11-24 12:05:27 -05:00
Andrew Steinborn 084b741375 Don't repeat validation in AvailableCommands
When deserializing an AvailableCommands packet, we do a few sanity checks to ensure the packet is valid. Some of this work was repeated for each cycle (notably the root) so we now check the children and any redirects are defined only once.
2020-11-24 12:03:34 -05:00
Andrew Steinborn dd8c670ef7 Velocity 1.1.3-SNAPSHOT 2020-11-22 12:04:07 -05:00
Andrew Steinborn 783054d098 Velocity 1.1.2 2020-11-22 12:00:47 -05:00
Andrew Steinborn 3d0cb50569 Better check for unfinished decompression 2020-11-17 04:48:20 -05:00
Andrew Steinborn 563a96e624 Bump Netty version 2020-11-17 04:38:24 -05:00
Andrew Steinborn 329e2b0dc9 Use our fork's removeChildByName 2020-11-16 13:09:47 -05:00
Andrew SteinbornandGitHub 7ead4add67 Support custom mod argument tunneling (#390) 2020-11-16 02:58:00 -05:00
Andrew Steinborn 511165415d Switch to our internal Brigadier fork 2020-11-15 23:33:16 -05:00
Andrew Steinborn 44f872eea4 Better validate addresses in configuration. Fixes #385 2020-11-07 20:43:58 -05:00
Andrew SteinbornandGitHub 09de77425d Merge pull request #387 from A248/fix-addToClasspath-preconditions
Permit passing PluginContainer to PluginManager#addToClasspath
2020-11-07 20:39:25 -05:00
Andrew Steinborn d51f357fa8 Avoid unneeded copy in BackendPlaySessionHandler plugin messages 2020-11-07 10:57:03 -05:00
Andrew Steinborn 8a3b6403da Wrap plugin message copies in unreleasable copies.
Trying to track down a very weird issue that barely makes sense to me.
2020-11-07 09:40:09 -05:00
Andrew Steinborn 89e1a07448 Try and explicitly specify Java 8 in the modules. 2020-11-06 18:52:00 -05:00
Andrew Steinborn fb888c3b8a Store players in VelocityRegisteredServer by UUID instead.
Fixes an issue where players would be repeated in /glist and the like.
2020-11-06 09:38:26 -05:00
Andrew Steinborn cc89a2a1e5 We don't need to retain/release the mod list buffer in readModList 2020-11-05 20:04:31 -05:00
Andrew Steinborn 91b295ead5 Further improve the inflate overflow checks in the Java 11 compressor native
This brings the Java compressor in line with our libdeflate one. Backport this from Velocity 2.0.0.
2020-11-05 17:22:19 -05:00
Andrew Steinborn 1f5b0e1e03 Fix a few minor issues with the Java 11 compressor 2020-11-05 17:07:49 -05:00
Andrew SteinbornandGitHub b78b091b33 Merge pull request #383 from Gabik21/fix-status-ping-17
Fix ping response being delayed on 1.7
2020-11-05 11:46:54 -05:00
Andrew Steinborn 642573e9e0 Fix logic for telling the server snapshot versions. 2020-11-04 18:58:48 -05:00
Andrew Steinborn 54c5effe27 Fix typos. 2020-11-03 16:06:30 -05:00
Andrew Steinborn d708716ef6 Use slower server switching sequence for Legacy Forge clients 2020-11-03 15:58:03 -05:00
Andrew Steinborn 325ab19102 Move out VarintByteDecoder to improve escape analysis 2020-11-03 12:55:02 -05:00